Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2187283002: [Turbofan] Soft deopt if we only have deprecated maps on optimization. (Closed)

Created:
4 years, 4 months ago by mvstanton
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Soft deopt if we only have deprecated maps on optimization. In native context specialization, we attempt to use map-based feedback to do optimized named and element loads and stores. Tragically, it could happen that any maps we encounter for a load have been deprecated. The right thing to do here is reoptimize later, let the IC subsystem update the map. BUG= Committed: https://crrev.com/8587c4ce6fb74186b9ee9639532cbfb016be2ce5 Cr-Commit-Position: refs/heads/master@{#38143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M src/compiler/js-native-context-specialization.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
mvstanton
Hi Benedikt, here is the CL we discussed, thx for the look, --Mike
4 years, 4 months ago (2016-07-28 13:14:23 UTC) #5
Benedikt Meurer
Awesome, very nice, thanks! LGTM.
4 years, 4 months ago (2016-07-28 16:39:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187283002/1
4 years, 4 months ago (2016-07-28 16:39:36 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 16:41:16 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 16:43:49 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8587c4ce6fb74186b9ee9639532cbfb016be2ce5
Cr-Commit-Position: refs/heads/master@{#38143}

Powered by Google App Engine
This is Rietveld 408576698