Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: src/compiler/js-native-context-specialization.cc

Issue 2187283002: [Turbofan] Soft deopt if we only have deprecated maps on optimization. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-native-context-specialization.cc
diff --git a/src/compiler/js-native-context-specialization.cc b/src/compiler/js-native-context-specialization.cc
index 53d6232eaa34752688592f1114f539b7daf81926..562511e159ae6e1a7064fbd6aafff8475392bf86 100644
--- a/src/compiler/js-native-context-specialization.cc
+++ b/src/compiler/js-native-context-specialization.cc
@@ -98,7 +98,10 @@ Reduction JSNativeContextSpecialization::ReduceNamedAccess(
}
// Nothing to do if we have no non-deprecated maps.
- if (access_infos.empty()) return NoChange();
+ if (access_infos.empty()) {
+ return ReduceSoftDeoptimize(
+ node, DeoptimizeReason::kInsufficientTypeFeedbackForGenericNamedAccess);
+ }
// The final states for every polymorphic branch. We join them with
// Merge++Phi+EffectPhi at the bottom.
@@ -517,7 +520,10 @@ Reduction JSNativeContextSpecialization::ReduceElementAccess(
}
// Nothing to do if we have no non-deprecated maps.
- if (access_infos.empty()) return NoChange();
+ if (access_infos.empty()) {
+ return ReduceSoftDeoptimize(
+ node, DeoptimizeReason::kInsufficientTypeFeedbackForGenericKeyedAccess);
+ }
// The final states for every polymorphic branch. We join them with
// Merge+Phi+EffectPhi at the bottom.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698