Fix applying non-chromium patches to ios trybots

Fix applying non-chromium patches to ios trybots

BUG=631575
Committed: https://chromium.googlesource.com/chromium/tools/build/+/10d4c37a58a56a1edafc49ae71684203e960b1eb

[Michael Achenbach, 2016-07-28 12:25:30]

Description was changed from

==========
Fix applying non-chromium patches to ios trybots

BUG=
==========

to

==========
Fix applying non-chromium patches to ios trybots

BUG=631575
==========

[Michael Achenbach, 2016-07-28 12:36:32]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 12:36:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 12:40:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 12:40:28]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-07-28 12:52:25]

machenbach@chromium.org changed reviewers:
+ smut@google.com, tandrii@chromium.org

[Michael Achenbach, 2016-07-28 12:52:25]

PTAL

https://codereview.chromium.org/2187253003/diff/1/scripts/slave/recipes/ios/t...
File scripts/slave/recipes/ios/try.expected/icu_patch.json (right):

https://codereview.chromium.org/2187253003/diff/1/scripts/slave/recipes/ios/t...
scripts/slave/recipes/ios/try.expected/icu_patch.json:215: "cwd":
"[SLAVE_BUILD]/src",
Here's the error: should be called in the icu directory.

https://codereview.chromium.org/2187253003/diff/1/scripts/slave/recipes/ios/t...
File scripts/slave/recipes/ios/try.py (right):

https://codereview.chromium.org/2187253003/diff/1/scripts/slave/recipes/ios/t...
scripts/slave/recipes/ios/try.py:83: yield (
This deserves a refactoring, but I saw that most test cases here are very
similar c/p. This now copies the above and adds:
patch_project='icu',

https://codereview.chromium.org/2187253003/diff/20001/scripts/slave/recipes/i...
File scripts/slave/recipes/ios/try.expected/icu_patch.json (right):

https://codereview.chromium.org/2187253003/diff/20001/scripts/slave/recipes/i...
scripts/slave/recipes/ios/try.expected/icu_patch.json:215: "cwd":
"[SLAVE_BUILD]/src/third_party/icu",
Here's the fix.

[tandrii(chromium), 2016-07-28 12:55:35]

lgtm

[Michael Achenbach, 2016-07-28 13:05:13]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-07-28 13:05:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 13:09:19]

Description was changed from

==========
Fix applying non-chromium patches to ios trybots

BUG=631575
==========

to

==========
Fix applying non-chromium patches to ios trybots

BUG=631575

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/10d4c37a58a56a1edafc...
==========

[commit-bot: I haz the power, 2016-07-28 13:09:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/10d4c37a58a56a1edafc...