Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2187253003: Fix applying non-chromium patches to ios trybots (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
Reviewers:
smut, tandrii(chromium)
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 : Test case showing the problem #

Total comments: 2

Patch Set 2 : Fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -9 lines) Patch
M scripts/slave/recipe_modules/ios/api.py View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/ios/try.py View 2 chunks +34 lines, -2 lines 0 comments Download
A + scripts/slave/recipes/ios/try.expected/icu_patch.json View 1 6 chunks +9 lines, -6 lines 1 comment Download

Messages

Total messages: 12 (8 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/2187253003/diff/1/scripts/slave/recipes/ios/try.expected/icu_patch.json File scripts/slave/recipes/ios/try.expected/icu_patch.json (right): https://codereview.chromium.org/2187253003/diff/1/scripts/slave/recipes/ios/try.expected/icu_patch.json#newcode215 scripts/slave/recipes/ios/try.expected/icu_patch.json:215: "cwd": "[SLAVE_BUILD]/src", Here's the error: should be called ...
4 years, 4 months ago (2016-07-28 12:52:25 UTC) #7
tandrii(chromium)
lgtm
4 years, 4 months ago (2016-07-28 12:55:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187253003/20001
4 years, 4 months ago (2016-07-28 13:05:26 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 13:09:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/10d4c37a58a56a1edafc...

Powered by Google App Engine
This is Rietveld 408576698