Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: scripts/slave/recipes/ios/try.py

Issue 2187253003: Fix applying non-chromium patches to ios trybots (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Test case showing the problem Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'depot_tools/gclient', 6 'depot_tools/gclient',
7 'ios', 7 'ios',
8 'recipe_engine/json', 8 'recipe_engine/json',
9 'recipe_engine/platform', 9 'recipe_engine/platform',
10 'recipe_engine/properties', 10 'recipe_engine/properties',
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 'tests': [ 72 'tests': [
73 { 73 {
74 'app': 'fake tests', 74 'app': 'fake tests',
75 'device type': 'fake device', 75 'device type': 'fake device',
76 'os': '8.1', 76 'os': '8.1',
77 }, 77 },
78 ], 78 ],
79 }) 79 })
80 ) 80 )
81 81
82 # The same test as above but applying an icu patch.
83 yield (
Michael Achenbach 2016/07/28 12:52:25 This deserves a refactoring, but I saw that most t
84 api.test('icu_patch')
85 + api.platform('mac', 64)
86 + api.properties(patch_url='patch url')
87 + api.properties(
88 buildername='ios-simulator',
89 buildnumber='0',
90 issue=123456,
91 mastername='tryserver.fake',
92 patchset=1,
93 patch_project='icu',
94 rietveld='fake://rietveld.url',
95 slavename='fake-vm',
96 )
97 + api.ios.make_test_build_config({
98 'xcode version': 'fake xcode version',
99 'GYP_DEFINES': {
100 'fake gyp define 1': 'fake value 1',
101 'fake gyp define 2': 'fake value 2',
102 },
103 'compiler': 'ninja',
104 'configuration': 'Debug',
105 'sdk': 'iphonesimulator8.0',
106 'tests': [
107 {
108 'app': 'fake tests',
109 'device type': 'fake device',
110 'os': '8.1',
111 },
112 ],
113 })
114 )
115
82 yield ( 116 yield (
83 api.test('parent') 117 api.test('parent')
84 + api.platform('mac', 64) 118 + api.platform('mac', 64)
85 + api.properties(patch_url='patch url') 119 + api.properties(patch_url='patch url')
86 + api.properties( 120 + api.properties(
87 buildername='ios', 121 buildername='ios',
88 buildnumber='0', 122 buildnumber='0',
89 issue=123456, 123 issue=123456,
90 mastername='tryserver.fake', 124 mastername='tryserver.fake',
91 patchset=1, 125 patchset=1,
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 'sdk': 'iphonesimulator8.0', 284 'sdk': 'iphonesimulator8.0',
251 'tests': [ 285 'tests': [
252 { 286 {
253 'app': 'fake tests', 287 'app': 'fake tests',
254 'device type': 'fake device', 288 'device type': 'fake device',
255 'os': '8.1', 289 'os': '8.1',
256 }, 290 },
257 ], 291 ],
258 }) 292 })
259 ) 293 )
260
261
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698