Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2187193002: Dont bail out of preload scanning if a appcache manifest is found (Closed)

Created:
4 years, 4 months ago by Charlie Harrison
Modified:
4 years, 4 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, Yoav Weiss, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Dont bail out of preload scanning if a appcache manifest is found The preload scanner bails if it sees an appcache manifest in the markup. This behavior isn't really correct, as we already wait for appcache to be initialized before sending out any requests. Also, there could be resources that still need to be loaded over the network. BUG=630717 Committed: https://crrev.com/91146fe960885eae005f3ac14f29dacc93a98dac Cr-Commit-Position: refs/heads/master@{#408304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h View 3 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 5 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Charlie Harrison
Kouhei@, can you take a look at this? Looks like you added the initial checks ...
4 years, 4 months ago (2016-07-28 00:10:32 UTC) #4
kouhei (in TOK)
lgtm Thanks for catching this
4 years, 4 months ago (2016-07-28 00:26:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2187193002/1
4 years, 4 months ago (2016-07-28 00:28:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 01:20:10 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 01:23:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91146fe960885eae005f3ac14f29dacc93a98dac
Cr-Commit-Position: refs/heads/master@{#408304}

Powered by Google App Engine
This is Rietveld 408576698