Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp

Issue 2187193002: Dont bail out of preload scanning if a appcache manifest is found (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
diff --git a/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp b/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
index 09e657f9aa8888892779c69314f82f0629107f1a..1d347377674597cb06a1744ffbc46c4128135be8 100644
--- a/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
+++ b/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
@@ -497,7 +497,6 @@ TokenPreloadScanner::TokenPreloadScanner(const KURL& documentURL, std::unique_pt
, m_inStyle(false)
, m_inPicture(false)
, m_inScript(false)
- , m_isAppCacheEnabled(false)
, m_isCSPEnabled(false)
, m_templateCount(0)
, m_documentParameters(std::move(documentParameters))
@@ -516,7 +515,7 @@ TokenPreloadScanner::~TokenPreloadScanner()
TokenPreloadScannerCheckpoint TokenPreloadScanner::createCheckpoint()
{
TokenPreloadScannerCheckpoint checkpoint = m_checkpoints.size();
- m_checkpoints.append(Checkpoint(m_predictedBaseElementURL, m_inStyle, m_inScript, m_isAppCacheEnabled, m_isCSPEnabled, m_templateCount));
+ m_checkpoints.append(Checkpoint(m_predictedBaseElementURL, m_inStyle, m_inScript, m_isCSPEnabled, m_templateCount));
return checkpoint;
}
@@ -526,7 +525,6 @@ void TokenPreloadScanner::rewindTo(TokenPreloadScannerCheckpoint checkpointIndex
const Checkpoint& checkpoint = m_checkpoints[checkpointIndex];
m_predictedBaseElementURL = checkpoint.predictedBaseElementURL;
m_inStyle = checkpoint.inStyle;
- m_isAppCacheEnabled = checkpoint.isAppCacheEnabled;
m_isCSPEnabled = checkpoint.isCSPEnabled;
m_templateCount = checkpoint.templateCount;
@@ -658,10 +656,6 @@ void TokenPreloadScanner::scanCommon(const Token& token, const SegmentedString&
if (!m_documentParameters->doHtmlPreloadScanning)
return;
- // Disable preload for documents with AppCache.
- if (m_isAppCacheEnabled)
- return;
-
// http://crbug.com/434230 Disable preload for documents with CSP <meta> tags
if (m_isCSPEnabled)
return;
@@ -725,10 +719,6 @@ void TokenPreloadScanner::scanCommon(const Token& token, const SegmentedString&
updatePredictedBaseURL(token);
return;
}
- if (match(tagImpl, htmlTag) && token.getAttributeItem(manifestAttr)) {
- m_isAppCacheEnabled = true;
- return;
- }
if (match(tagImpl, metaTag)) {
const typename Token::Attribute* equivAttribute = token.getAttributeItem(http_equivAttr);
if (equivAttribute) {
« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698