Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2187153003: Fuchsia: Builds run_vm_tests and a wrapper program for running it. (Closed)

Created:
4 years, 4 months ago by zra
Modified:
4 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://chromium.googlesource.com/external/github.com/dart-lang/sdk/@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fuchsia: Builds run_vm_tests and a wrapper program for running it. This CL adds rules to the GN build for building run_vm_tests for Fuchsia. It also adds a wrapper program in //runtime/bin/run_vm_tests_fuchsia.cc and a file containing the output of 'run_vm_tests --list', //runtime/bin/fuchsia_vm_tests.txt. The wrapper program and text file make it easier to run the tests on Fuchsia, and should be able to go away once we are out of the bootstrapping phase. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/5475ab6fbba1539051c9234dd26034cc6430c617

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1284 lines, -16 lines) Patch
M runtime/bin/BUILD.gn View 1 chunk +84 lines, -0 lines 0 comments Download
A runtime/bin/fuchsia_vm_tests.txt View 1 chunk +915 lines, -0 lines 0 comments Download
A runtime/bin/run_vm_tests_fuchsia.cc View 1 chunk +255 lines, -0 lines 0 comments Download
M runtime/tools/create_string_literal.py View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/BUILD.gn View 3 chunks +7 lines, -16 lines 0 comments Download
M tools/gypi_to_gn.py View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 4 months ago (2016-07-27 22:35:06 UTC) #2
siva
lgtm
4 years, 4 months ago (2016-07-28 17:23:58 UTC) #3
zra
4 years, 4 months ago (2016-07-28 17:35:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5475ab6fbba1539051c9234dd26034cc6430c617 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698