third_party/WebKit/Source/platform/peerconnection/RTCStatsResponseBase.h - Issue 2186853002: WebRTCStats added, retaining type info when surfacing WebRTC stats into Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/peerconnection/RTCStatsResponseBase.h

Issue 2186853002: WebRTCStats added, retaining type info when surfacing WebRTC stats into Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed tommi's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/exported/WebRTCStatsResponse.cpp ('k') | third_party/WebKit/public/blink_headers.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/peerconnection/RTCStatsResponseBase.h

diff --git a/third_party/WebKit/Source/platform/peerconnection/RTCStatsResponseBase.h b/third_party/WebKit/Source/platform/peerconnection/RTCStatsResponseBase.h

index 2c7068c0299320069e5abff9bf57061c401b61c5..09a79891c630800bad0f3ff92337c12ac0ae5587 100644

--- a/third_party/WebKit/Source/platform/peerconnection/RTCStatsResponseBase.h

+++ b/third_party/WebKit/Source/platform/peerconnection/RTCStatsResponseBase.h

@@ -25,6 +25,7 @@

#ifndef RTCStatsResponseBase_h

#define RTCStatsResponseBase_h

+#include "public/platform/WebRTCStats.h"

#include "wtf/Forward.h"

namespace blink {

@@ -33,8 +34,7 @@ class RTCStatsResponseBase : public GarbageCollectedFinalized<RTCStatsResponseBa

public:

virtual ~RTCStatsResponseBase() { }

- virtual size_t addReport(const String& id, const String& type, double timestamp) = 0;

- virtual void addStatistic(size_t report, const String& name, const String& value) = 0;

+ virtual void addStats(const WebRTCStats&) = 0;

DEFINE_INLINE_VIRTUAL_TRACE() { }

};