third_party/WebKit/Source/platform/exported/WebRTCStatsResponse.cpp - Issue 2186853002: WebRTCStats added, retaining type info when surfacing WebRTC stats into Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebRTCStatsResponse.cpp

Issue 2186853002: WebRTCStats added, retaining type info when surfacing WebRTC stats into Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed tommi's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.cpp ('k') | third_party/WebKit/Source/platform/peerconnection/RTCStatsResponseBase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/exported/WebRTCStatsResponse.cpp

diff --git a/third_party/WebKit/Source/platform/exported/WebRTCStatsResponse.cpp b/third_party/WebKit/Source/platform/exported/WebRTCStatsResponse.cpp

index 05a598d4c51777f7ed76827594157db5de1db1f2..dd06f3391600da2a6a9b03baaee8abc30b89b42f 100644

--- a/third_party/WebKit/Source/platform/exported/WebRTCStatsResponse.cpp

+++ b/third_party/WebKit/Source/platform/exported/WebRTCStatsResponse.cpp

@@ -49,16 +49,10 @@ WebRTCStatsResponse::operator RTCStatsResponseBase*() const

return m_private.get();

}

-size_t WebRTCStatsResponse::addReport(const WebString& id, const WebString& type, double timestamp)

+void WebRTCStatsResponse::addStats(const WebRTCStats& stats)

{

ASSERT(!m_private.isNull());

- return m_private->addReport(id, type, timestamp);

-void WebRTCStatsResponse::addStatistic(size_t report, const WebString& name, const WebString& value)

- ASSERT(!m_private.isNull());

- m_private->addStatistic(report, name, value);

+ m_private->addStats(stats);

}

} // namespace blink