chrome/browser/media/webrtc_browsertest_base.cc - Issue 2186853002: WebRTCStats added, retaining type info when surfacing WebRTC stats into Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/webrtc_browsertest_base.cc

Issue 2186853002: WebRTCStats added, retaining type info when surfacing WebRTC stats into Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed phoglund's comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/webrtc_browsertest_base.h ('k') | chrome/test/data/webrtc/peerconnection.js » ('j') | chrome/test/data/webrtc/peerconnection.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/webrtc_browsertest_base.cc

diff --git a/chrome/browser/media/webrtc_browsertest_base.cc b/chrome/browser/media/webrtc_browsertest_base.cc

index 2213da9f1c64c33f069546e4b51c8d60692b5003..5a189152c63ea0d238ed6639c262964771913306 100644

--- a/chrome/browser/media/webrtc_browsertest_base.cc

+++ b/chrome/browser/media/webrtc_browsertest_base.cc

@@ -485,3 +485,8 @@ void WebRtcTestBase::GenerateAndCloneCertificate(

EXPECT_EQ("ok-generated-and-cloned", response) << "Failed to generate and "

"clone certificate: " << response;

}

+void WebRtcTestBase::VerifyStatsGenerated(content::WebContents* tab) const {

+ std::string response = ExecuteJavascript("verifyStatsGenerated()", tab);

+ EXPECT_EQ("ok-got-stats", response) << "Failed to get stats: " << response;

tommi (sloooow) - chröme 2016/07/27 18:38:40 doesn't EXPECT_EQ already print out the contents o

hbos_chromium 2016/07/28 08:27:45 You're right, fixed here and above while I'm at it

« no previous file with comments | « chrome/browser/media/webrtc_browsertest_base.h ('k') | chrome/test/data/webrtc/peerconnection.js » ('j') | chrome/test/data/webrtc/peerconnection.js » ('J')