chrome/browser/media/webrtc_browsertest_base.cc - Issue 2186853002: WebRTCStats added, retaining type info when surfacing WebRTC stats into Blink

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/media/webrtc_browsertest_base.cc

Issue 2186853002: WebRTCStats added, retaining type info when surfacing WebRTC stats into Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed phoglund's comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/media/webrtc_browsertest_base.h"	5 #include "chrome/browser/media/webrtc_browsertest_base.h"

6	6

7 #include <stddef.h>	7 #include <stddef.h>

8	8

9 #include "base/lazy_instance.h"	9 #include "base/lazy_instance.h"

10 #include "base/macros.h"	10 #include "base/macros.h"

(...skipping 467 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
478 }	478 }

479	479

480 void WebRtcTestBase::GenerateAndCloneCertificate(	480 void WebRtcTestBase::GenerateAndCloneCertificate(

481 content::WebContents* tab, const std::string& keygen_algorithm) const {	481 content::WebContents* tab, const std::string& keygen_algorithm) const {

482 std::string javascript = base::StringPrintf(	482 std::string javascript = base::StringPrintf(

483 "generateAndCloneCertificate(%s)", keygen_algorithm.c_str());	483 "generateAndCloneCertificate(%s)", keygen_algorithm.c_str());

484 std::string response = ExecuteJavascript(javascript, tab);	484 std::string response = ExecuteJavascript(javascript, tab);

485 EXPECT_EQ("ok-generated-and-cloned", response) << "Failed to generate and "	485 EXPECT_EQ("ok-generated-and-cloned", response) << "Failed to generate and "

486 "clone certificate: " << response;	486 "clone certificate: " << response;

487 }	487 }

	488

	489 void WebRtcTestBase::VerifyStatsGenerated(content::WebContents* tab) const {

	490 std::string response = ExecuteJavascript("verifyStatsGenerated()", tab);

	491 EXPECT_EQ("ok-got-stats", response) << "Failed to get stats: " << response;
	tommi (sloooow) - chröme 2016/07/27 18:38:40 doesn't EXPECT_EQ already print out the contents o doesn't EXPECT_EQ already print out the contents of the variables? hbos_chromium 2016/07/28 08:27:45 You're right, fixed here and above while I'm at it Show quoted text On 2016/07/27 18:38:40, tommi-chrömium wrote: > doesn't EXPECT_EQ already print out the contents of the variables? You're right, fixed here and above while I'm at it.
	492 }

OLD	NEW

« no previous file with comments | « chrome/browser/media/webrtc_browsertest_base.h ('k') | chrome/test/data/webrtc/peerconnection.js » ('j') | chrome/test/data/webrtc/peerconnection.js » ('J')