Issue 2186833002: DevTools: ensure to show the same Popover object only once.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2186833002: DevTools: ensure to show the same Popover object only once. (Closed)

Created:
4 years, 4 months ago by Malcolm

Modified:
4 years, 4 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

DevTools: ensure to show the same Popover object only once. BUG=630920 TEST=manually tested.

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/WebKit/Source/devtools/front_end/ui/Popover.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pfeldman

On 2016/07/27 07:32:11, Malcolm wrote: > Please review this CL, thanks! I'm fixing the underlying ...

4 years, 4 months ago (2016-07-29 00:35:25 UTC) #3

Malcolm

4 years, 4 months ago (2016-07-29 07:51:30 UTC) #4

On 2016/07/29 00:35:25, pfeldman wrote:
> On 2016/07/27 07:32:11, Malcolm wrote:
> > Please review this CL, thanks!
> 
> I'm fixing the underlying issue at https://codereview.chromium.org/2190213002/

I see, by applying it, the bug is fixed!

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages