third_party/WebKit/Source/devtools/front_end/ui/Popover.js - Issue 2186833002: DevTools: ensure to show the same Popover object only once.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Popover.js

Issue 2186833002: DevTools: ensure to show the same Popover object only once. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/ui/Popover.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Popover.js b/third_party/WebKit/Source/devtools/front_end/ui/Popover.js

index c17ef693ca9fd348085efafcf871bd880e1ae049..f6431a003ce2e3072faf2536482e26fac98d67d0 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/Popover.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/Popover.js

@@ -83,7 +83,7 @@ WebInspector.Popover.prototype = {

_innerShow: function(view, contentElement, anchor, preferredWidth, preferredHeight, arrowDirection)

{

- if (this._disposed)

+ if (this._disposed || WebInspector.Popover._popover === this)

return;

this._contentElement = contentElement;

« no previous file with comments | « no previous file | no next file » | no next file with comments »