Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 218683011: Remove ExtensionService::[Get|Is]InstalledApp() (Closed)

Created:
6 years, 8 months ago by Devlin
Modified:
6 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, nkostylev+watch_chromium.org, tzik, tfarina, nhiroki, marja+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, chromium-apps-reviews_chromium.org, kinuko+watch, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dc_ces_get_installed_ext_by_url
Visibility:
Public.

Description

Remove ExtensionService::GetInstalledApp() and ExtensionService::IsInstalledApp() Move GetInstalledApp() to ExtensionSet::GetAppByURL(). - More accurately named. - Forces callers to understand that they are only searching the given extension set (GetInstalledApp() implied it may have searched more than just enabled extensions). Remove IsInstalledApp(), since this was used in only two places and can be substituted with GetAppByUrl() != NULL. BUG=351891 TBR=dzhioev@chromium.org (c/b/chromeos/first_run/) TBR=kinuko@chromium.org (c/b/sync_file_system/) TBR=nick@chromium.org (c/b/task_manager/) (All TBRs are for strictly mechanical changes) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263075

Patch Set 1 : #

Patch Set 2 : Also remove ExtensionService::IsInstalledApp() #

Patch Set 3 : Latest master #

Total comments: 2

Patch Set 4 : Mac fix #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -90 lines) Patch
M chrome/browser/autocomplete/extension_app_provider.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/first_run/drive_first_run_controller.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 4 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 1 2 3 4 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service_helper.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_service.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/task_manager/tab_contents_information.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_app_tab_helper.cc View 1 2 3 4 2 chunks +14 lines, -7 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 2 3 4 5 chunks +14 lines, -18 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 2 3 4 5 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/core_app_launcher_handler.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M extensions/common/extension_set.h View 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/common/extension_set.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
Devlin
When time allows.
6 years, 8 months ago (2014-04-01 17:44:45 UTC) #1
Devlin
When time allows.
6 years, 8 months ago (2014-04-01 17:44:46 UTC) #2
Yoyo Zhou
LGTM
6 years, 8 months ago (2014-04-03 22:25:14 UTC) #3
Devlin
sky@, mind taking a quick look at c/b/ui? Shouldn't be any functional changes anywhere, but, ...
6 years, 8 months ago (2014-04-04 21:03:49 UTC) #4
sky
https://codereview.chromium.org/218683011/diff/60001/chrome/browser/ui/ash/launcher/launcher_app_tab_helper.cc File chrome/browser/ui/ash/launcher/launcher_app_tab_helper.cc (right): https://codereview.chromium.org/218683011/diff/60001/chrome/browser/ui/ash/launcher/launcher_app_tab_helper.cc#newcode29 chrome/browser/ui/ash/launcher/launcher_app_tab_helper.cc:29: if (!ExtensionSystem::Get(profile)->extension_service()->extensions_enabled()) We seem to have all sorts of ...
6 years, 8 months ago (2014-04-04 21:21:13 UTC) #5
Devlin
https://codereview.chromium.org/218683011/diff/60001/chrome/browser/ui/ash/launcher/launcher_app_tab_helper.cc File chrome/browser/ui/ash/launcher/launcher_app_tab_helper.cc (right): https://codereview.chromium.org/218683011/diff/60001/chrome/browser/ui/ash/launcher/launcher_app_tab_helper.cc#newcode29 chrome/browser/ui/ash/launcher/launcher_app_tab_helper.cc:29: if (!ExtensionSystem::Get(profile)->extension_service()->extensions_enabled()) On 2014/04/04 21:21:13, sky wrote: > We ...
6 years, 8 months ago (2014-04-04 21:24:14 UTC) #6
sky
Ok, LGTM
6 years, 8 months ago (2014-04-04 21:29:22 UTC) #7
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 8 months ago (2014-04-08 15:08:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/218683011/140001
6 years, 8 months ago (2014-04-08 15:09:10 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-08 16:22:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-08 16:22:58 UTC) #11
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 8 months ago (2014-04-08 16:25:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/218683011/140001
6 years, 8 months ago (2014-04-08 16:25:57 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-08 16:27:39 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-08 16:27:39 UTC) #15
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 8 months ago (2014-04-08 19:20:02 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/218683011/140001
6 years, 8 months ago (2014-04-08 19:20:25 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-08 20:29:51 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-08 20:29:51 UTC) #19
ncarter (slow)
task manager lgtm
6 years, 8 months ago (2014-04-10 14:19:29 UTC) #20
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 8 months ago (2014-04-10 16:42:46 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/218683011/180001
6 years, 8 months ago (2014-04-10 16:43:01 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 17:50:45 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-10 17:50:46 UTC) #24
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 8 months ago (2014-04-10 18:44:45 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/218683011/200001
6 years, 8 months ago (2014-04-10 18:45:45 UTC) #26
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 21:00:41 UTC) #27
Message was sent while issue was closed. 
Change committed as 263075

Powered by Google App Engine
This is Rietveld 408576698