chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc - Issue 218683011: Remove ExtensionService::[Get|Is]InstalledApp()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 218683011: Remove ExtensionService::[Get|Is]InstalledApp() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dc_ces_get_installed_ext_by_url

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/startup/startup_browser_creator_impl.cc ('k') | chrome/browser/ui/webui/ntp/core_app_launcher_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

index aa4a15b2c4effd089c3e84a7dbcb4ab6988933c1..4ac18d5615b24b918e91bd21c87c12c03b2f712d 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

@@ -20,7 +20,6 @@

#include "chrome/browser/browser_process.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/defaults.h"

-#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/search/search.h"

#include "chrome/browser/sync/profile_sync_service.h"

@@ -57,6 +56,9 @@

#include "content/public/browser/user_metrics.h"

#include "content/public/browser/web_contents.h"

#include "content/public/common/page_transition_types.h"

+#include "extensions/browser/extension_registry.h"

+#include "extensions/common/extension.h"

+#include "extensions/common/extension_set.h"

#include "grit/generated_resources.h"

#include "grit/theme_resources.h"

#include "grit/ui_resources.h"

@@ -311,9 +313,9 @@ class OverFlowButton : public views::MenuButton {

};

void RecordAppLaunch(Profile* profile, GURL url) {

- DCHECK(profile->GetExtensionService());

const extensions::Extension* extension =

- profile->GetExtensionService()->GetInstalledApp(url);

+ extensions::ExtensionRegistry::Get(profile)

+ ->enabled_extensions().GetAppByURL(url);

if (!extension)

return;