Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2186773002: Revert of Devtools Color: Basic support for #RRGGBBAA and #RGBA (Closed)

Created:
4 years, 4 months ago by luoe
Modified:
4 years, 4 months ago
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Devtools Color: Basic support for #RRGGBBAA and #RGBA (patchset #4 id:80001 of https://codereview.chromium.org/1986053004/ ) Reason for revert: [DevTools] Entering a HEX value into color picker and changing opacity results in an 8-digit HEX, currently seen as invalid. This should reland once 8-digit hex (#rrggbbaa) is a fully supported value for colors (once #76362 lands). Original issue's description: > Devtools Color: Basic support for #RRGGBBAA and #RGBA > > BUG=611687 > > Committed: https://crrev.com/97c7757e7ae143f63e5d7281d1a9837338b12562 > Cr-Commit-Position: refs/heads/master@{#395801} TBR=dgozman@chromium.org,lushnikov@chromium.org,noel@chromium.org,pfeldman@chromium.org,samli@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=630808 Committed: https://crrev.com/c404fce6e03e11f64b4e136f3aa533f33ddaecad Cr-Commit-Position: refs/heads/master@{#408153}

Patch Set 1 #

Patch Set 2 : Manual revert #

Messages

Total messages: 23 (14 generated)
luoe
Created Revert of Devtools Color: Basic support for #RRGGBBAA and #RGBA
4 years, 4 months ago (2016-07-26 23:06:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186773002/1
4 years, 4 months ago (2016-07-26 23:07:08 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-07-26 23:07:10 UTC) #5
lushnikov
rs lgtm
4 years, 4 months ago (2016-07-26 23:26:25 UTC) #11
luoe
Manual revert required since Spectrum.js moved recently. Most of the changes were copy/pasting code, ensuring ...
4 years, 4 months ago (2016-07-27 16:27:32 UTC) #16
lushnikov
lgtm
4 years, 4 months ago (2016-07-27 16:42:57 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186773002/200001
4 years, 4 months ago (2016-07-27 16:43:51 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:200001)
4 years, 4 months ago (2016-07-27 16:48:56 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 16:51:51 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c404fce6e03e11f64b4e136f3aa533f33ddaecad
Cr-Commit-Position: refs/heads/master@{#408153}

Powered by Google App Engine
This is Rietveld 408576698