Issue 2186753006: Turn off ASAN for non-default toolchains for win clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2186753006: Turn off ASAN for non-default toolchains for win clang. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke

Modified:
4 years, 4 months ago

Reviewers:
etienneb, Roland McGrath

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Turn off ASAN for non-default toolchains for win clang. R=mcgrathr@chromium.org, etienneb@chromium.org BUG=598761

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	build/toolchain/win/BUILD.gn	View		5 chunks	+13 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Dirk Pranke

On 2016/07/29 14:37:06, etienneb wrote: > rubber stamp lgtm I think this is the right ...

4 years, 4 months ago (2016-07-29 15:17:48 UTC) #3

Roland McGrath

It's not at all clear why you're turning is_asan off in each context. Comments seem ...

4 years, 4 months ago (2016-07-29 18:18:32 UTC) #4

Dirk Pranke

4 years, 4 months ago (2016-08-02 01:08:21 UTC) #5

I think we can fold this into https://codereview.chromium.org/2198333002/ or an
equivalent.