Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2186703002: Remove ThreadTest.Restart (Closed)

Created:
4 years, 4 months ago by gab
Modified:
4 years, 4 months ago
Reviewers:
danakj
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ThreadTest.Restart I had missed its existence as part of https://codereview.chromium.org/2145463002/ and its now superseeded by ThreadTest.StartTwice and ThreadTest.StopTwiceNop. BUG=629139 Committed: https://crrev.com/63f8f4eb236c7aa8bb8505bd372487e3a529baee Cr-Commit-Position: refs/heads/master@{#407913}

Patch Set 1 #

Total comments: 2

Patch Set 2 : check !IsRunning() before Start() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -22 lines) Patch
M base/threading/thread_unittest.cc View 1 3 chunks +5 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
gab
Mini-CL :-)
4 years, 4 months ago (2016-07-26 19:37:46 UTC) #4
danakj
LGTM 1 thing: https://codereview.chromium.org/2186703002/diff/1/base/threading/thread_unittest.cc File base/threading/thread_unittest.cc (right): https://codereview.chromium.org/2186703002/diff/1/base/threading/thread_unittest.cc#newcode197 base/threading/thread_unittest.cc:197: EXPECT_TRUE(a.Start()); can you check messageloop/IsRunning before ...
4 years, 4 months ago (2016-07-26 19:41:10 UTC) #5
gab
https://codereview.chromium.org/2186703002/diff/1/base/threading/thread_unittest.cc File base/threading/thread_unittest.cc (right): https://codereview.chromium.org/2186703002/diff/1/base/threading/thread_unittest.cc#newcode197 base/threading/thread_unittest.cc:197: EXPECT_TRUE(a.Start()); On 2016/07/26 19:41:09, danakj wrote: > can you ...
4 years, 4 months ago (2016-07-26 20:32:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186703002/20001
4 years, 4 months ago (2016-07-26 20:33:40 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-26 21:09:46 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 21:11:15 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63f8f4eb236c7aa8bb8505bd372487e3a529baee
Cr-Commit-Position: refs/heads/master@{#407913}

Powered by Google App Engine
This is Rietveld 408576698