Remove ThreadTest.Restart

base/threading/thread_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/threading/thread.h"
 
 #include <stddef.h>
 
 #include <vector>
 
@@ skipping 102 matching lines @@
 // signal |event|.
 void ReturnThreadId(base::Thread* thread,
                     base::PlatformThreadId* id,
                     base::WaitableEvent* event) {
   *id = thread->GetThreadId();
   event->Signal();
 }
 
 }  // namespace
 
-TEST_F(ThreadTest, Restart) {
-  Thread a("Restart");
-  a.Stop();
-  EXPECT_FALSE(a.message_loop());
-  EXPECT_FALSE(a.IsRunning());
-  EXPECT_TRUE(a.Start());
-  EXPECT_TRUE(a.message_loop());
-  EXPECT_TRUE(a.IsRunning());
-  a.Stop();
-  EXPECT_FALSE(a.message_loop());
-  EXPECT_FALSE(a.IsRunning());
-  EXPECT_TRUE(a.Start());
-  EXPECT_TRUE(a.message_loop());
-  EXPECT_TRUE(a.IsRunning());
-  a.Stop();
-  EXPECT_FALSE(a.message_loop());
-  EXPECT_FALSE(a.IsRunning());
-  a.Stop();
-  EXPECT_FALSE(a.message_loop());
-  EXPECT_FALSE(a.IsRunning());
-}
-
 TEST_F(ThreadTest, StartWithOptions_StackSize) {
   Thread a("StartWithStackSize");
   // Ensure that the thread can work with only 12 kb and still process a
   // message.
   Thread::Options options;
 #if defined(ADDRESS_SANITIZER)
   // ASan bloats the stack variables and overflows the 12 kb stack.
   options.stack_size = 24*1024;
 #else
   options.stack_size = 12*1024;
@@ skipping 54 matching lines @@
   EXPECT_FALSE(a.message_loop());
   EXPECT_FALSE(a.IsRunning());
   // Calling them when not running should also nop.
   a.StopSoon();
   a.Stop();
 }
 
 TEST_F(ThreadTest, StartTwice) {
   Thread a("StartTwice");
 
   EXPECT_TRUE(a.Start());

[danakj, 2016/07/26 19:41:09]

can you check messageloop/IsRunning before calling Start()?

[gab, 2016/07/26 20:32:49]

Done.

   EXPECT_TRUE(a.message_loop());
   EXPECT_TRUE(a.IsRunning());
   a.Stop();
   EXPECT_FALSE(a.message_loop());
   EXPECT_FALSE(a.IsRunning());
 
   EXPECT_TRUE(a.Start());
   EXPECT_TRUE(a.message_loop());
   EXPECT_TRUE(a.IsRunning());
   a.Stop();
@@ skipping 95 matching lines @@
   EXPECT_FALSE(a.task_runner());
 }
 
 TEST_F(ThreadTest, MultipleWaitUntilThreadStarted) {
   Thread a("MultipleWaitUntilThreadStarted");
   EXPECT_TRUE(a.Start());
   // It's OK to call WaitUntilThreadStarted() multiple times.
   EXPECT_TRUE(a.WaitUntilThreadStarted());
   EXPECT_TRUE(a.WaitUntilThreadStarted());
 }