Remove virtual destructor from WorkerSettings, and make the constructor explicit.

Remove virtual destructor from WorkerSettings, and make the constructor explicit.

It has no base or derived classes, so its destructor need not be declared virtual.

It has a one-argument constructor, which per the style guide should be declared
'explicit' to avoid undesired implicit conversions.

Committed: https://crrev.com/63942671b93caa41959910a47bc834c5c68df15c
Cr-Commit-Position: refs/heads/master@{#407922}

[jbroman, 2016-07-26 18:07:30]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 18:08:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2016-07-26 18:08:11]

Description was changed from

==========
Remove virtual destructor from WorkerSettings.

It has no derived classes, so its destructor need not be declared virtual.
==========

to

==========
Remove virtual destructor from WorkerSettings.

It has no base or derived classes, so its destructor need not be declared
virtual.
==========

[jbroman, 2016-07-26 18:11:20]

jbroman@chromium.org changed reviewers:
+ xlai@chromium.org

[jbroman, 2016-07-26 18:11:20]

Noticed this virtual destructor was left behind during the refactor in the
previous patch set. This should be a simple cleanup; PTAL.

[jbroman, 2016-07-26 18:12:10]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[jbroman, 2016-07-26 18:12:23]

Description was changed from

==========
Remove virtual destructor from WorkerSettings.

It has no base or derived classes, so its destructor need not be declared
virtual.
==========

to

==========
Remove virtual destructor from WorkerSettings, and make the constructor
explicit.

It has no base or derived classes, so its destructor need not be declared
virtual.

It has a one-argument constructor, which per the style guide should be declared
'explicit' to avoid undesired implicit conversions.
==========

[jbroman, 2016-07-26 18:12:39]

(and a one-argument constructor that should be explicit, also trivial)

[commit-bot: I haz the power, 2016-07-26 18:12:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 20:30:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 20:30:45]

Dry run: This issue passed the CQ dry run.

[xlai (Olivia), 2016-07-26 21:30:30]

lgtm. Thanks for the cleanup

[xlai (Olivia), 2016-07-26 21:30:48]

The CQ bit was checked by xlai@chromium.org

[commit-bot: I haz the power, 2016-07-26 21:32:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 21:36:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-26 21:38:33]

Description was changed from

==========
Remove virtual destructor from WorkerSettings, and make the constructor
explicit.

It has no base or derived classes, so its destructor need not be declared
virtual.

It has a one-argument constructor, which per the style guide should be declared
'explicit' to avoid undesired implicit conversions.
==========

to

==========
Remove virtual destructor from WorkerSettings, and make the constructor
explicit.

It has no base or derived classes, so its destructor need not be declared
virtual.

It has a one-argument constructor, which per the style guide should be declared
'explicit' to avoid undesired implicit conversions.

Committed: https://crrev.com/63942671b93caa41959910a47bc834c5c68df15c
Cr-Commit-Position: refs/heads/master@{#407922}
==========

[commit-bot: I haz the power, 2016-07-26 21:38:34]

Patchset 2 (id:??) landed as
https://crrev.com/63942671b93caa41959910a47bc834c5c68df15c
Cr-Commit-Position: refs/heads/master@{#407922}