third_party/WebKit/Source/core/workers/WorkerSettings.h - Issue 2186663002: Remove virtual destructor from WorkerSettings, and make the constructor explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerSettings.h

Issue 2186663002: Remove virtual destructor from WorkerSettings, and make the constructor explicit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: explicit constructor Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/workers/WorkerSettings.h

diff --git a/third_party/WebKit/Source/core/workers/WorkerSettings.h b/third_party/WebKit/Source/core/workers/WorkerSettings.h

index 31443c50cb8e08a028e6aa4cfb781fe7b17780a6..e353055010f107360620c86928161fe84af8b52a 100644

--- a/third_party/WebKit/Source/core/workers/WorkerSettings.h

+++ b/third_party/WebKit/Source/core/workers/WorkerSettings.h

@@ -12,8 +12,7 @@ namespace blink {

class CORE_EXPORT WorkerSettings {

public:

- WorkerSettings(Settings*);

- virtual ~WorkerSettings() {}

+ explicit WorkerSettings(Settings*);

bool disableReadingFromCanvas() const { return m_disableReadingFromCanvas; }

« no previous file with comments | « no previous file | no next file » | no next file with comments »