LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/regular-block-becomes-multicol.html - Issue 218663004: Changing between multicol and regular block shouldn't recreate all renderers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/regular-block-becomes-multicol.html

Issue 218663004: Changing between multicol and regular block shouldn't recreate all renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Actually test switching between multicol and non-multicol using the new implementation as well. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/multicol/multicol-becomes-regular-block-expected.html ('K') | « LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/multicol-becomes-regular-block-expected.html ('k') | LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/regular-block-becomes-multicol-expected.html » ('j') | Source/core/rendering/RenderBlockFlow.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/regular-block-becomes-multicol.html

diff --git a/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/regular-block-becomes-multicol.html b/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/regular-block-becomes-multicol.html

new file mode 100644

index 0000000000000000000000000000000000000000..a9c913d625ece9daaa648ce4b961bcdb67a6b3cc

--- /dev/null

+++ b/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/regular-block-becomes-multicol.html

@@ -0,0 +1,26 @@

+<!DOCTYPE html>

+<html>

+ <head>

+ <script>

+ if (window.internals)

+ internals.settings.setRegionBasedColumnsEnabled(true);

+ function test() {

+ var elm = document.getElementById('elm');

+ elm.offsetTop; // trigger layout

+ elm.style.WebkitColumns = 4;

+ elm.style.columns = 4;

+ }

+ </script>

+ </head>

+ <body onload="test()">

+ <p>You should see the word 'PASS' below.</p>

+ <div style="font-family:monospace; float:left;">

+ <div id="elm" style="-webkit-column-gap:0; column-gap:0; orphans:1; widows:1;">

+ P<br>

+ A<br>

+ S<br>

+ </div>

+ </body>

+</html>