LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/regular-block-becomes-multicol.html - Issue 218663004: Changing between multicol and regular block shouldn't recreate all renderers.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/regular-block-becomes-multicol.html

Issue 218663004: Changing between multicol and regular block shouldn't recreate all renderers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Actually test switching between multicol and non-multicol using the new implementation as well. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/multicol/multicol-becomes-regular-block-expected.html ('K') | « LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/multicol-becomes-regular-block-expected.html ('k') | LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/regular-block-becomes-multicol-expected.html » ('j') | Source/core/rendering/RenderBlockFlow.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script>

	5 if (window.internals)

	6 internals.settings.setRegionBasedColumnsEnabled(true);

	7 function test() {

	8 var elm = document.getElementById('elm');

	9 elm.offsetTop; // trigger layout

	10 elm.style.WebkitColumns = 4;

	11 elm.style.columns = 4;

	12 }

	13 </script>

	14 </head>

	15 <body onload="test()">

	16 <p>You should see the word 'PASS' below.</p>

	17 <div style="font-family:monospace; float:left;">

	18 <div id="elm" style="-webkit-column-gap:0; column-gap:0; orphans:1; widows:1;">

	19 P<br>

	20 A<br>

	21 S<br>

	22 S<br>

	23 </div>

	24 </div>

	25 </body>

	26 </html>

OLD	NEW