Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2186553003: Update two layout tests to reflect bleeding in ctx.drawImage (Closed)

Created:
4 years, 4 months ago by xidachen
Modified:
4 years, 4 months ago
CC:
chromium-reviews, blink-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update two layout tests to reflect bleeding in ctx.drawImage With this skia change: https://codereview.chromium.org/2176193002/, canvas drawImage() API call does bleeding, so these two layout tests needs to be updated. We need to rebase line fast/images/paint-subrect-grid.html, which is marked as failure at this moment. The test fast/canvas/DrawImageSinglePixelStretch.html has been re-written to canvas-drawImage-bleed.html BUG=355305 Committed: https://crrev.com/1bda333fbc22ef6db35892b1105dfbf7b27e4dc4 Cr-Commit-Position: refs/heads/master@{#407959}

Patch Set 1 #

Patch Set 2 : update expected png #

Patch Set 3 : rebase #

Messages

Total messages: 17 (8 generated)
xidachen
PTAL
4 years, 4 months ago (2016-07-26 13:49:20 UTC) #2
Stephen Chennney
Could you include sample test results, even if they get rebaselined after the patch lands? ...
4 years, 4 months ago (2016-07-26 14:00:44 UTC) #3
xidachen
On 2016/07/26 14:00:44, Stephen Chennney wrote: > Could you include sample test results, even if ...
4 years, 4 months ago (2016-07-26 14:06:57 UTC) #4
Stephen Chennney
LGTM
4 years, 4 months ago (2016-07-26 18:35:33 UTC) #5
xidachen
junov@: could you take a look? I delete DrawImageSinglePixelStretch.html, and rewrite it as canvas-drawImage-bleed.html Thanks.
4 years, 4 months ago (2016-07-26 19:29:01 UTC) #6
Justin Novosad
lgtm
4 years, 4 months ago (2016-07-26 20:35:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186553003/40001
4 years, 4 months ago (2016-07-26 23:13:28 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-26 23:17:19 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 23:18:43 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1bda333fbc22ef6db35892b1105dfbf7b27e4dc4
Cr-Commit-Position: refs/heads/master@{#407959}

Powered by Google App Engine
This is Rietveld 408576698