Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2186473002: Reland of current program can be null in ES2/ES3 contexts. (Closed)

Created:
4 years, 4 months ago by Zhenyao Mo
Modified:
4 years, 4 months ago
Reviewers:
yunchao, Mark P, piman
CC:
chromium-reviews, piman+watch_chromium.org, yunchao
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of current program can be null in ES2/ES3 contexts. (patchset #1 id:1 of https://codereview.chromium.org/2181193002/ ) Reason for revert: I don't think this is related. See crbug.com/631316 and here the conversion between me and Mark. Original issue's description: > Revert of current program can be null in ES2/ES3 contexts. (patchset #2 id:20001 of https://codereview.chromium.org/2174173002/ ) > > Reason for revert: > Caused webkit test failure on WebKit Win7 (dbg) > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/6624 > > unexpected_failures: > printing/webgl-oversized-printing.html > virtual/threaded/printing/webgl-oversized-printing.html > > https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg_/6624/layout-test-results/results.html > > --- > --- E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-expected.txt > +++ E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-actual.txt > @@ -1,5 +1,5 @@ > -PASS successfullyParsed is true > +CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor' of null > +FAIL successfullyParsed should be true. Was false. > > TEST COMPLETE > -PASS Printed without crashing. > --- > > --- > --- E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-expected.txt > +++ E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-actual.txt > @@ -1,5 +1,5 @@ > -PASS successfullyParsed is true > +CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor' of null > +FAIL successfullyParsed should be true. Was false. > > TEST COMPLETE > -PASS Printed without crashing. > --- > > Original issue's description: > > current program can be null in ES2/ES3 contexts. > > > > They are only required to be non null in WebGL. > > > > This also did some clean up and a minor optimization. > > > > BUG=630802 > > TEST=fuzzer case in the bug > > R=piman@chromium.org > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > > > Committed: https://crrev.com/14ef40159115ca5059907835a34bcd1667af7631 > > Cr-Commit-Position: refs/heads/master@{#407659} > > TBR=piman@chromium.org,yunchao.he@intel.com,zmo@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=630802 > > Committed: https://crrev.com/e9c2cd979c8114b75bbc2640a43a1371d64f502b > Cr-Commit-Position: refs/heads/master@{#407711} TBR=piman@chromium.org,yunchao.he@intel.com,mpearson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630802 Committed: https://crrev.com/773ceaef513c9e81fde791b6fe4612fd46cfb7fd Cr-Commit-Position: refs/heads/master@{#407713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -95 lines) Patch
M gpu/command_buffer/service/context_state.h View 2 chunks +14 lines, -18 lines 0 comments Download
M gpu/command_buffer/service/context_state.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +29 lines, -17 lines 0 comments Download
M gpu/command_buffer/service/program_manager.h View 3 chunks +11 lines, -16 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 3 chunks +17 lines, -17 lines 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager.h View 2 chunks +7 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager.cc View 2 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Zhenyao Mo
Created Reland of current program can be null in ES2/ES3 contexts.
4 years, 4 months ago (2016-07-26 05:09:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186473002/1
4 years, 4 months ago (2016-07-26 05:09:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 05:10:16 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 05:12:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/773ceaef513c9e81fde791b6fe4612fd46cfb7fd
Cr-Commit-Position: refs/heads/master@{#407713}

Powered by Google App Engine
This is Rietveld 408576698