Issue 2186433002: TBR. Shouldn't have referenced JSObject in dart2js. Accidentally left it in porting code from darti…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2186433002: TBR. Shouldn't have referenced JSObject in dart2js. Accidentally left it in porting code from darti… (Closed)

Created:
4 years, 4 months ago by Jacob

Modified:
4 years, 4 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

TBR. Shouldn't have referenced JSObject in dart2js. Accidentally left it in porting code from dartium. BUG= Committed: https://github.com/dart-lang/sdk/commit/31f1f9caf306cdd829d0625b4aea74267e12942e

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -4 lines)			Patch
M	sdk/lib/dart2dart.platform	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/dart_client.platform	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/dart_shared.platform	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/js_util/dart2js/js_util_dart2js.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (2 generated)

Jacob

4 years, 4 months ago (2016-07-26 01:55:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
31f1f9caf306cdd829d0625b4aea74267e12942e.