sdk/lib/js_util/dart2js/js_util_dart2js.dart - Issue 2186433002: TBR. Shouldn't have referenced JSObject in dart2js. Accidentally left it in porting code from darti…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/js_util/dart2js/js_util_dart2js.dart

Issue 2186433002: TBR. Shouldn't have referenced JSObject in dart2js. Accidentally left it in porting code from darti… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Removing js_util from this list makes the platform consistency test pass but that seems like the wr… Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/js_util/dart2js/js_util_dart2js.dart

diff --git a/sdk/lib/js_util/dart2js/js_util_dart2js.dart b/sdk/lib/js_util/dart2js/js_util_dart2js.dart

index da9b3677956241e292fa4ba03b404fb4b2f93159..a58745977906f0b2d83d7d7ccfae453f7860f0fd 100644

--- a/sdk/lib/js_util/dart2js/js_util_dart2js.dart

+++ b/sdk/lib/js_util/dart2js/js_util_dart2js.dart

@@ -56,7 +56,7 @@ _convertDataTree(data) {

return _convert(data);

}

-JSObject newObject() => JS('=Object', '{}');

+newObject() => JS('=Object', '{}');

hasProperty(o, name) => JS('bool', '# in #', name, o);

getProperty(o, name) => JS('Object', '#[#]', o, name);

« no previous file with comments | « sdk/lib/dart_shared.platform ('k') | no next file » | no next file with comments »