List header files explicitly in BUILD.gn

List header files explicitly in BUILD.gn

Private headers are listed in source[] while public headers are listed
in public[] for icuuc and icu18n targets.

This change is to let trybot analyze step recompile icuuc or icu18n even
when the only change in CL is in a header file (public or private).

BUG=632438
TEST=`gn check <out_dir>` does not complain.
TEST=`gn ref <out_dir> third_party/icu/source/common/umutex.h` matches icuuc.
TEST=`gn ref <out_dir> third_party/icu/source/common/unicode/unistr.h`
     matches icuuc.

R=brettw@chromium.org

Committed: https://chromium.googlesource.com/chromium/deps/icu/+/56680aaa9aafe50996f5bd88c88d0dacf0e897db

[jungshik at Google, 2016-07-29 22:35:12]

Description was changed from

==========
List header files explicitly in BUILD.gn

Private headers are listed in source[] while public headers are listed
in public[] for icuuc and icu18n targets.

BUG=632438
TEST=gn check <out_dir> does not complain.
TEST=`gn ref <out_dir> source/common/umutex.h` matches icuuc.
TEST=`gn ref <out_dir> source/common/unicode/unistr.h` matches icuuc.
==========

to

==========
List header files explicitly in BUILD.gn

Private headers are listed in source[] while public headers are listed
in public[] for icuuc and icu18n targets.

BUG=632438
TEST=gn check <out_dir> does not complain.
TEST=`gn ref <out_dir> third_party/icu/source/common/umutex.h` matches icuuc.
TEST=`gn ref <out_dir> third_party/icu/source/common/unicode/unistr.h` matches
icuuc.
==========

[jungshik at Google, 2016-07-29 22:54:11]

Description was changed from

==========
List header files explicitly in BUILD.gn

Private headers are listed in source[] while public headers are listed
in public[] for icuuc and icu18n targets.

BUG=632438
TEST=gn check <out_dir> does not complain.
TEST=`gn ref <out_dir> third_party/icu/source/common/umutex.h` matches icuuc.
TEST=`gn ref <out_dir> third_party/icu/source/common/unicode/unistr.h` matches
icuuc.
==========

to

==========
List header files explicitly in BUILD.gn

Private headers are listed in source[] while public headers are listed
in public[] for icuuc and icu18n targets.

This change is to let trybot analyze step recompile icuuc or icu18n when the
only change in CL is in a header file (public or private).

BUG=632438
TEST=gn check <out_dir> does not complain.
TEST=`gn ref <out_dir> third_party/icu/source/common/umutex.h` matches icuuc.
TEST=`gn ref <out_dir> third_party/icu/source/common/unicode/unistr.h` matches
icuuc.
==========

[jungshik at Google, 2016-07-29 22:58:06]

jshin@chromium.org changed reviewers:
+ brettw@chromium.org

[jungshik at Google, 2016-07-29 22:58:06]

Hi Brett, can you take a look?  

I'm asking you to review it because you might have not listed header files on
purpose for a reason unknown to me when you first made this BUILD.gn file. 

Build-wise, nothing is wrong with the current version. However, analyze step in
trybot does not work as expected without header files listed explicitly. 

An alternative to this CL might be to change the behavior of 'gn refs' (to take
into account 'include_dirs'), but I'm not sure if it's a good idea. 

Thanks

[brettw, 2016-08-01 17:54:54]

Anything in here, if I did it, was just copy-and-pasted from GYP.

LGTM

[brettw, 2016-08-01 17:54:55]

Anything in here, if I did it, was just copy-and-pasted from GYP.

LGTM

[jungshik at Google, 2016-08-02 21:30:12]

Description was changed from

==========
List header files explicitly in BUILD.gn

Private headers are listed in source[] while public headers are listed
in public[] for icuuc and icu18n targets.

This change is to let trybot analyze step recompile icuuc or icu18n when the
only change in CL is in a header file (public or private).

BUG=632438
TEST=gn check <out_dir> does not complain.
TEST=`gn ref <out_dir> third_party/icu/source/common/umutex.h` matches icuuc.
TEST=`gn ref <out_dir> third_party/icu/source/common/unicode/unistr.h` matches
icuuc.
==========

to

==========
List header files explicitly in BUILD.gn

Private headers are listed in source[] while public headers are listed
in public[] for icuuc and icu18n targets.

This change is to let trybot analyze step recompile icuuc or icu18n even
when the only change in CL is in a header file (public or private).

BUG=632438
TEST=`gn check <out_dir>` does not complain.
TEST=`gn ref <out_dir> third_party/icu/source/common/umutex.h` matches icuuc.
TEST=`gn ref <out_dir> third_party/icu/source/common/unicode/unistr.h`
     matches icuuc.
==========

[jungshik at Google, 2016-08-02 21:30:22]

Description was changed from

==========
List header files explicitly in BUILD.gn

Private headers are listed in source[] while public headers are listed
in public[] for icuuc and icu18n targets.

This change is to let trybot analyze step recompile icuuc or icu18n even
when the only change in CL is in a header file (public or private).

BUG=632438
TEST=`gn check <out_dir>` does not complain.
TEST=`gn ref <out_dir> third_party/icu/source/common/umutex.h` matches icuuc.
TEST=`gn ref <out_dir> third_party/icu/source/common/unicode/unistr.h`
     matches icuuc.
==========

to

==========
List header files explicitly in BUILD.gn

Private headers are listed in source[] while public headers are listed
in public[] for icuuc and icu18n targets.

This change is to let trybot analyze step recompile icuuc or icu18n even
when the only change in CL is in a header file (public or private).

BUG=632438
TEST=`gn check <out_dir>` does not complain.
TEST=`gn ref <out_dir> third_party/icu/source/common/umutex.h` matches icuuc.
TEST=`gn ref <out_dir> third_party/icu/source/common/unicode/unistr.h`
     matches icuuc.

R=brettw@chromium.org

Committed:
https://chromium.googlesource.com/chromium/deps/icu/+/56680aaa9aafe50996f5bd8...
==========

[jungshik at Google, 2016-08-02 21:30:24]

Committed patchset #2 (id:20001) manually as
56680aaa9aafe50996f5bd88c88d0dacf0e897db (presubmit successful).

[jungshik at Google, 2016-08-02 21:31:47]

On 2016/08/01 17:54:55, brettw (ping on IM after 24h) wrote:
> Anything in here, if I did it, was just copy-and-pasted from GYP.
> 
> LGTM

Thanks !