Stop doing unnecessary initialization in non-SFI

ppapi/native_client/src/trusted/plugin/plugin.cc

Index: ppapi/native_client/src/trusted/plugin/plugin.cc
diff --git a/ppapi/native_client/src/trusted/plugin/plugin.cc b/ppapi/native_client/src/trusted/plugin/plugin.cc
index e98c4c89902c1ac763fa2a80fb0c957f802e148d..74eb9dc255bb06f88bbe6b20fbdaf83aada0a9f2 100644
--- a/ppapi/native_client/src/trusted/plugin/plugin.cc
+++ b/ppapi/native_client/src/trusted/plugin/plugin.cc
@@ -346,8 +346,9 @@ void Plugin::LoadNaClModule(nacl::DescWrapper* wrapper,
   // associated listener threads do not go unjoined because if they
   // outlive the Plugin object, they will not be memory safe.
   ShutDownSubprocesses();
+  const bool uses_irt = !uses_nonsfi_mode;

[Mark Seaborn, 2014/04/01 14:35:36]

It might be slightly preferable to do this in nacl_process_host.cc instead, i.e.

  params.uses_irt = uses_irt_ && !uses_nonsfi_mode_;

since this stops the renderer requesting a non-working combination.

[hamaji, 2014/04/03 07:05:54]

Done.

   SelLdrStartParams params(manifest_base_url(),
-                           true /* uses_irt */,
+                           uses_irt,
                            true /* uses_ppapi */,
                            uses_nonsfi_mode,
                            enable_dev_interfaces_,