Stop doing unnecessary initialization in non-SFI

ppapi/native_client/src/trusted/plugin/plugin.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifdef _MSC_VER
 // Do not warn about use of std::copy with raw pointers.
 #pragma warning(disable : 4996)
 #endif
 
 #include "ppapi/native_client/src/trusted/plugin/plugin.h"
@@ skipping 328 matching lines @@
                             bool enable_crash_throttling,
                             const pp::CompletionCallback& init_done_cb,
                             const pp::CompletionCallback& crash_cb) {
   nacl::scoped_ptr<nacl::DescWrapper> scoped_wrapper(wrapper);
   CHECK(pp::Module::Get()->core()->IsMainThread());
   // Before forking a new sel_ldr process, ensure that we do not leak
   // the ServiceRuntime object for an existing subprocess, and that any
   // associated listener threads do not go unjoined because if they
   // outlive the Plugin object, they will not be memory safe.
   ShutDownSubprocesses();
+  const bool uses_irt = !uses_nonsfi_mode;

[Mark Seaborn, 2014/04/01 14:35:36]

It might be slightly preferable to do this in nacl_process_host.cc instead, i.e.

  params.uses_irt = uses_irt_ && !uses_nonsfi_mode_;

since this stops the renderer requesting a non-working combination.

[hamaji, 2014/04/03 07:05:54]

Done.

   SelLdrStartParams params(manifest_base_url(),
-                           true /* uses_irt */,
+                           uses_irt,
                            true /* uses_ppapi */,
                            uses_nonsfi_mode,
                            enable_dev_interfaces_,
                            enable_dyncode_syscalls,
                            enable_exception_handling,
                            enable_crash_throttling);
   ErrorInfo error_info;
   ServiceRuntime* service_runtime =
       new ServiceRuntime(this, manifest_.get(), true, uses_nonsfi_mode,
                          init_done_cb, crash_cb);
@@ skipping 1084 matching lines @@
   DCHECK(pp::Module::Get()->core()->IsMainThread());
   DCHECK(nacl_interface_);
   exit_status_ = exit_status;
   nacl_interface_->SetReadOnlyProperty(pp_instance(),
                                        pp::Var("exitStatus").pp_var(),
                                        pp::Var(exit_status_).pp_var());
 }
 
 
 }  // namespace plugin