[Android] Provide unhandled tap event notifications

[Android] Reland "Provide unhandled tap event notifications"

Allow notifications of unhandled taps via the GestureStateListener.  This change
makes GestureTap events blocking, but there are several use-cases for which this
will be necessary, e.g., WebView and contextual search.

This patch has quite the history, having landed in r26143 and r266732 only to be
reverted in r261470 and r266832 because of a flaky test.  The text has been
(hopefully, probably) fixed with additional input from the test owner.

BUG=355154
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267258

[jdduke (slow), 2014-03-31 21:51:37]

PTAL.  mkosiba@, eventually we'll need to adapt the API for it to be of
immediate use to your proposed listener API (need the touch id), but it turns
out there are other people interested in this notification (donnd@ and the
contextual search folks).

tdresser@: I know we fought to make GestureTap non-blocking, and I thought of
special-casing the exception for Android, but Android is probably the primary
platform that benefits from a non-blocking GestureTap =/

[Donn Denman, 2014-03-31 22:46:10]

lgtm

Thanks for doing this!

[tdresser, 2014-04-01 13:04:14]

On 2014/03/31 22:46:10, Donn Denman wrote:
> lgtm
> 
> Thanks for doing this!

Yeah, I'm in favor of consistency between Aura and Android here.
SGTM.

[mkosiba (inactive), 2014-04-01 14:03:51]

lgtm although it looks like you have a legit content_browsertests failure

[jdduke (slow), 2014-04-01 15:39:22]

tedchoc@: Owner review for content/public/android? Thanks.

[Ted C, 2014-04-01 15:44:46]

content/public/android - lgtm

[jdduke (slow), 2014-04-01 15:45:19]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-01 15:46:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/40001

[commit-bot: I haz the power, 2014-04-01 17:12:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-01 17:12:02]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[jdduke (slow), 2014-04-01 19:54:55]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-01 19:55:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/60001

[commit-bot: I haz the power, 2014-04-01 22:46:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/60001

[commit-bot: I haz the power, 2014-04-02 00:24:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-02 00:24:45]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[jdduke (slow), 2014-04-02 20:03:40]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-02 20:04:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/60001

[commit-bot: I haz the power, 2014-04-03 01:23:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 01:23:07]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[jdduke (slow), 2014-04-03 01:28:13]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-03 01:36:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/60001

[commit-bot: I haz the power, 2014-04-03 08:32:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 08:32:39]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[jdduke (slow), 2014-04-03 13:21:45]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-03 13:21:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/60001

[commit-bot: I haz the power, 2014-04-03 13:24:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 13:24:35]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[jdduke (slow), 2014-04-03 13:25:36]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-03 13:25:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/60001

[commit-bot: I haz the power, 2014-04-03 15:00:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 15:00:52]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[jdduke (slow), 2014-04-03 15:04:15]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-03 15:06:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/60001

[commit-bot: I haz the power, 2014-04-03 16:06:16]

Change committed as 261431

[jdduke (slow), 2014-04-03 17:45:15]

A revert of this CL has been created in
https://codereview.chromium.org/224273002/ by jdduke@chromium.org.

The reason for reverting is: Legitimate browsertest failure..

[jdduke (slow), 2014-04-03 18:11:05]

ben@: Review for
content/browser/web_contents/touch_editable_impl_aura_browsertest.cc? Thanks.

[jdduke (slow), 2014-04-04 03:26:52]

https://codereview.chromium.org/218633008/diff/110001/content/browser/web_con...
File content/browser/web_contents/touch_editable_impl_aura_browsertest.cc
(right):

https://codereview.chromium.org/218633008/diff/110001/content/browser/web_con...
content/browser/web_contents/touch_editable_impl_aura_browsertest.cc:329:
blink::WebInputEvent::GestureTap)) {
tdresser@: What am I missing here?  Looks like this test is still failing...

[tdresser, 2014-04-04 13:28:18]

https://codereview.chromium.org/218633008/diff/110001/content/browser/web_con...
File content/browser/web_contents/touch_editable_impl_aura_browsertest.cc
(right):

https://codereview.chromium.org/218633008/diff/110001/content/browser/web_con...
content/browser/web_contents/touch_editable_impl_aura_browsertest.cc:329:
blink::WebInputEvent::GestureTap)) {
On 2014/04/04 03:26:53, jdduke wrote:
> tdresser@: What am I missing here?  Looks like this test is still failing...

Hmmm, I can't repro the failure locally, with a "use_aura=1 use_ash=1
chromeos=1" build... I'm really not sure what's going on here.


Are you positive that waiting for the ack waits long enough? Do you need to:

touch_editable->Reset();
touch_editable->WaitForGestureAck();
touch_editable->WaitForSelectionChangeCallback();

[jdduke (slow), 2014-04-08 10:53:55]

sky@: I think ben@ may be out of town? Looking for OWNER approval for
content/browser/web_contents/touch_editable_impl_aura_browsertest.cc.  Thanks.

[sky, 2014-04-08 15:58:24]

content/browser/web_contents/touch_editable_impl_aura_browsertest.cc LGTM

[jdduke (slow), 2014-04-08 19:35:05]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-08 19:35:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/150001

[commit-bot: I haz the power, 2014-04-08 20:26:12]

Change committed as 262497

[tapted, 2014-04-08 21:58:52]

A revert of this CL has been created in
https://codereview.chromium.org/229373002/ by tapted@chromium.org.

The reason for reverting is:
TouchEditableImplAuraTest.TouchCursorInTextfieldTest failing in the waterfall on
Linux ChromiumOS Tests (2) 
link:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....

[jdduke (slow), 2014-04-08 22:12:17]

On 2014/04/08 21:58:52, tapted wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/229373002/ by mailto:tapted@chromium.org.
> 
> The reason for reverting is:
> TouchEditableImplAuraTest.TouchCursorInTextfieldTest failing in the waterfall
on
> Linux ChromiumOS Tests (2) 
> link:
>
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....

... I give up... The CQ is failing me.

[jdduke (slow), 2014-04-25 00:25:52]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-25 00:26:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/180001

[jdduke (slow), 2014-04-25 00:29:41]

The CQ bit was unchecked by jdduke@chromium.org

[jdduke (slow), 2014-04-25 00:30:42]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-25 00:31:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/180001

[commit-bot: I haz the power, 2014-04-25 02:51:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 02:51:44]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[jdduke (slow), 2014-04-25 17:02:17]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-25 21:46:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/200001

[commit-bot: I haz the power, 2014-04-25 22:41:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 22:41:44]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[jdduke (slow), 2014-04-26 05:20:23]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-26 05:21:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/200001

[commit-bot: I haz the power, 2014-04-26 06:13:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 06:13:14]

Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

[jdduke (slow), 2014-04-28 14:57:35]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-28 14:58:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/200001

[commit-bot: I haz the power, 2014-04-28 14:58:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 14:58:24]

Failed to apply patch for
content/browser/renderer_host/input/input_router_impl_unittest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
content/browser/renderer_host/input/input_router_impl_unittest.cc
  Hunk #1 FAILED at 1285.
  Hunk #2 FAILED at 1312.
  2 out of 2 hunks FAILED -- saving rejects to file
content/browser/renderer_host/input/input_router_impl_unittest.cc.rej

Patch:       content/browser/renderer_host/input/input_router_impl_unittest.cc
Index: content/browser/renderer_host/input/input_router_impl_unittest.cc
diff --git a/content/browser/renderer_host/input/input_router_impl_unittest.cc
b/content/browser/renderer_host/input/input_router_impl_unittest.cc
index
0fbb1b32c4a2c05cd16c607cf58641bb71e6c430..fd5a84034ba4f57d97c6dcbbfa956f4b5fc536ed
100644
--- a/content/browser/renderer_host/input/input_router_impl_unittest.cc
+++ b/content/browser/renderer_host/input/input_router_impl_unittest.cc
@@ -1285,12 +1285,17 @@ TEST_F(InputRouterImplTest,
DoubleTapGestureDependsOnFirstTap) {
   EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
 
   // The GestureTapUnconfirmed is converted into a tap, as the touch action is
-  // auto.
+  // none.
   SimulateGestureEvent(WebInputEvent::GestureTapUnconfirmed,
                        WebGestureEvent::Touchscreen);
+  EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
+  // This test will become invalid if GestureTap stops requiring an ack.
+  ASSERT_TRUE(!WebInputEventTraits::IgnoresAckDisposition(
+      WebInputEvent::GestureTap));
+  EXPECT_EQ(2, client_->in_flight_event_count());
   SendInputEventACK(WebInputEvent::GestureTap,
                     INPUT_EVENT_ACK_STATE_CONSUMED);
-  EXPECT_EQ(1U, GetSentMessageCountAndResetSink());
+  EXPECT_EQ(1, client_->in_flight_event_count());
 
   // This tap gesture is dropped, since the GestureTapUnconfirmed was turned
   // into a tap.
@@ -1312,8 +1317,10 @@ TEST_F(InputRouterImplTest,
DoubleTapGestureDependsOnFirstTap) {
   SimulateGestureEvent(WebInputEvent::GestureDoubleTap,
                        WebGestureEvent::Touchscreen);
   // This test will become invalid if GestureDoubleTap stops requiring an ack.
-  DCHECK(!WebInputEventTraits::IgnoresAckDisposition(
+  ASSERT_TRUE(!WebInputEventTraits::IgnoresAckDisposition(
       WebInputEvent::GestureDoubleTap));
+  EXPECT_EQ(1, client_->in_flight_event_count());
+  SendInputEventACK(WebInputEvent::GestureTap, INPUT_EVENT_ACK_STATE_CONSUMED);
   EXPECT_EQ(0, client_->in_flight_event_count());
 }

[jdduke (slow), 2014-04-28 15:07:35]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-28 15:08:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/220001

[commit-bot: I haz the power, 2014-04-28 15:16:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 15:16:13]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_clang_dbg

[jdduke (slow), 2014-04-29 18:02:35]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-29 18:04:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/250001

[jdduke (slow), 2014-04-29 19:32:19]

The CQ bit was unchecked by jdduke@chromium.org

[jdduke (slow), 2014-04-29 21:20:02]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-29 21:21:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/270001

[commit-bot: I haz the power, 2014-04-29 22:19:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 22:19:04]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium

[jdduke (slow), 2014-04-29 22:33:10]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-29 22:33:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/270001

[commit-bot: I haz the power, 2014-04-30 00:33:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-30 00:33:27]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium

[jdduke (slow), 2014-04-30 15:49:01]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-04-30 15:49:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdduke@chromium.org/218633008/270001

[commit-bot: I haz the power, 2014-04-30 17:59:45]

Change committed as 267258