[Android] Provide unhandled tap event notifications

content/browser/web_contents/touch_editable_impl_aura_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/touch_editable_impl_aura.h"
 
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/test_timeouts.h"
 #include "base/values.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/browser/web_contents/web_contents_view_aura.h"
+#include "content/common/input/web_input_event_traits.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents_view.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/content_browser_test.h"
 #include "content/public/test/content_browser_test_utils.h"
 #include "content/public/test/test_utils.h"
 #include "content/shell/browser/shell.h"
 #include "ui/aura/test/event_generator.h"
 #include "ui/aura/window.h"
@@ skipping 293 matching lines @@
     aura::test::EventGenerator generator(content->GetRootWindow(), content);
     gfx::Rect bounds = content->GetBoundsInRootWindow();
     EXPECT_EQ(touch_editable->rwhva_, rwhva);
 
     ExecuteSyncJSFunction(main_frame, "focus_textfield()");
     touch_editable->WaitForSelectionChangeCallback();
 
     // Tap textfield
     touch_editable->Reset();
     generator.GestureTapAt(gfx::Point(bounds.x() + 50, bounds.y() + 40));
-    // Tap Down and Tap acks are sent synchronously.
-    touch_editable->WaitForSelectionChangeCallback();
-    touch_editable->Reset();
+    if (WebInputEventTraits::IgnoresAckDisposition(
+            blink::WebInputEvent::GestureTap)) {

[jdduke (slow), 2014/04/04 03:26:53]

tdresser@: What am I missing here?  Looks like this test is still failing...

[tdresser, 2014/04/04 13:28:19]

Hmmm, I can't repro the failure locally, with a "use_aura=1 use_ash=1
chromeos=1" build... I'm really not sure what's going on here.


Are you positive that waiting for the ack waits long enough? Do you need to:

touch_editable->Reset();
touch_editable->WaitForGestureAck();
touch_editable->WaitForSelectionChangeCallback();

+      touch_editable->WaitForSelectionChangeCallback();
+      touch_editable->Reset();
+    } else {
+      touch_editable->Reset();
+      touch_editable->WaitForGestureAck();
+    }
 
     // Check if cursor handle is showing.
     ui::TouchSelectionController* controller =
         touch_editable->touch_selection_controller_.get();
     EXPECT_NE(ui::TEXT_INPUT_TYPE_NONE, touch_editable->text_input_type_);
     EXPECT_TRUE(controller);
 
     scoped_ptr<base::Value> value =
         content::ExecuteScriptAndGetValue(main_frame, "get_cursor_position()");
     int cursor_pos = -1;
@@ skipping 35 matching lines @@
                        TouchSelectionOnLongPressTest) {
   TestTouchSelectionOnLongPress();
 }
 
 IN_PROC_BROWSER_TEST_F(TouchEditableImplAuraTest,
                        TouchCursorInTextfieldTest) {
   TestTouchCursorInTextfield();
 }
 
 }  // namespace content