Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 218623015: [IME] InputMethodUtil should cache the hardware layouts from VPD, instead of the filtered hardware … (Closed)

Created:
6 years, 8 months ago by Shu Chen
Modified:
6 years, 8 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

[IME] InputMethodUtil should cache the hardware layouts from VPD, instead of the filtered hardware layouts. So that GetHardwareLoginLayouts() can be called more than once when InputMethodUtil is init'ed or not init'ed. And don't use SetInputMethodLoginDefault() in OOBE, use EnableLoginLayouts() instead, because SetInputMethodLoginDefault() will default select the previous activated layout. BUG=358249, 358591 TEST=Verified on pixel. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261372

Patch Set 1 #

Patch Set 2 : fix the translate issue. #

Patch Set 3 : #

Patch Set 4 : rebased. #

Patch Set 5 : fixed test failures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M chrome/browser/chromeos/input_method/input_method_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 2 3 4 4 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/oobe_localization_browsertest.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Shu Chen
Nona, can you pls take a look? Thanks, Shu
6 years, 8 months ago (2014-04-01 07:27:52 UTC) #1
Seigo Nonaka
lgtm
6 years, 8 months ago (2014-04-01 08:16:57 UTC) #2
Shu Chen
Nikita, can you please review this cl? The change for OOBE needs your approval. Thanks, ...
6 years, 8 months ago (2014-04-02 06:52:36 UTC) #3
Nikita (slow)
Does the 3rd patchset fully fixes the bug though? See https://code.google.com/p/chromium/issues/detail?id=358249#c29
6 years, 8 months ago (2014-04-02 08:21:19 UTC) #4
Shu Chen
On 2014/04/02 08:21:19, Nikita Kostylev wrote: > Does the 3rd patchset fully fixes the bug ...
6 years, 8 months ago (2014-04-02 08:34:41 UTC) #5
Nikita (slow)
lgtm Assuming that you've also included my fix https://codereview.chromium.org/220693003 in your testing.
6 years, 8 months ago (2014-04-02 08:40:43 UTC) #6
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 8 months ago (2014-04-02 14:34:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/218623015/60001
6 years, 8 months ago (2014-04-02 14:35:15 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 19:29:14 UTC) #9
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=60475
6 years, 8 months ago (2014-04-02 19:29:14 UTC) #10
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 8 months ago (2014-04-03 04:33:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/218623015/80001
6 years, 8 months ago (2014-04-03 04:35:10 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 11:33:42 UTC) #13
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-04-03 11:33:43 UTC) #14
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 8 months ago (2014-04-03 12:20:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/218623015/80001
6 years, 8 months ago (2014-04-03 12:21:37 UTC) #16
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 12:25:34 UTC) #17
Message was sent while issue was closed.
Change committed as 261372

Powered by Google App Engine
This is Rietveld 408576698