Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 220693003: [oobe] Postpone localized content reload till WebUI is ready (Closed)

Created:
6 years, 8 months ago by Nikita (slow)
Modified:
6 years, 8 months ago
Reviewers:
ygorshenin1
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

[oobe] Postpone localized content reload till WebUI is ready This fixes bug with keyboard list not being translated. BUG=358591 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260894

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 5 chunks +19 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nikita (slow)
6 years, 8 months ago (2014-04-01 10:47:20 UTC) #1
ygorshenin1
lgtm
6 years, 8 months ago (2014-04-01 12:35:01 UTC) #2
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 8 months ago (2014-04-01 12:46:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/220693003/1
6 years, 8 months ago (2014-04-01 12:46:38 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 13:31:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-01 13:31:37 UTC) #6
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 8 months ago (2014-04-01 15:39:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/220693003/1
6 years, 8 months ago (2014-04-01 15:39:46 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 17:06:59 UTC) #9
Message was sent while issue was closed. 
Change committed as 260894

Powered by Google App Engine
This is Rietveld 408576698