Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2186213002: Revert of Ensure BrowserThread::CurrentlyOn is correct through MessageLoop teardown (Closed)

Created:
4 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Ensure BrowserThread::CurrentlyOn is correct through MessageLoop teardown (patchset #8 id:160001 of https://codereview.chromium.org/2180253003/ ) Reason for revert: Test failures in the changes to the ComponentCloudPolicyTest. Doh. Original issue's description: > Ensure BrowserThread::CurrentlyOn is correct through MessageLoop teardown > > Changes BrowserThread::CurrentlyOn (and thus > BrowserThreadTaskRunner::RunsTasksOnCurrentThread()) to correctly report > a BrowserThread's association during MessageLoop destruction notification. > > Also adds an explicit Start() to BrowserThreadImpl as there are tests which > call it and which incorrectly assumed base::Thread's implementation would > call BrowserThreadImpl::StartWithOptions (which it wouldn't since the latter > is not a virtual function.) > > This change provokes many tests to delete ExtensionFunction instances that > were otherwise being leaked because UIThreadExtensionFunction::Destroy was > incorrectly deferring destruction when run on the UI thread during shutdown. > This in turn revealed a few small bugs which have also been fixed here. > > BUG=631093 > R=jam@chromium.org > > Committed: https://crrev.com/b02da29fb9116d1a1fb4fd0476628f333ff6bd1a > Cr-Commit-Position: refs/heads/master@{#408295} TBR=jam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=631093 Committed: https://crrev.com/dd05854bb54363ce7d57ad1bedfe8df33ad76191 Cr-Commit-Position: refs/heads/master@{#408311}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -115 lines) Patch
M chrome/browser/browser_process_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/protocol_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_thread_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 5 chunks +8 lines, -37 lines 0 comments Download
M content/browser/browser_thread_unittest.cc View 5 chunks +1 line, -57 lines 0 comments Download
M extensions/browser/extension_function.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Ken Rockot(use gerrit already)
Created Revert of Ensure BrowserThread::CurrentlyOn is correct through MessageLoop teardown
4 years, 4 months ago (2016-07-28 02:03:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186213002/1
4 years, 4 months ago (2016-07-28 02:03:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 02:04:40 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 02:06:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd05854bb54363ce7d57ad1bedfe8df33ad76191
Cr-Commit-Position: refs/heads/master@{#408311}

Powered by Google App Engine
This is Rietveld 408576698