chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc - Issue 2186213002: Revert of Ensure BrowserThread::CurrentlyOn is correct through MessageLoop teardown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

Issue 2186213002: Revert of Ensure BrowserThread::CurrentlyOn is correct through MessageLoop teardown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browser_process_impl.cc ('k') | chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

diff --git a/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc b/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

index 023abc089131f95ac92d8e0c536d6a4781e11d7c..fa734bcedea523accad4bd0a352009b8404e290d 100644

--- a/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

+++ b/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

@@ -138,11 +138,6 @@

ExtensionBrowserTest::SetUpOnMainThread();

}

- void TearDownOnMainThread() override {

- event_listener_.reset();

- ExtensionBrowserTest::TearDownOnMainThread();

- }

scoped_refptr<const extensions::Extension> LoadExtension(

const base::FilePath::CharType* path) {

base::FilePath full_path;

@@ -261,9 +256,6 @@

}

IN_PROC_BROWSER_TEST_F(ComponentCloudPolicyTest, InstallNewExtension) {

- event_listener_->Reply(std::string());

- event_listener_.reset();

EXPECT_TRUE(test_server_.UpdatePolicyData(

dm_protocol::kChromeExtensionPolicyType, kTestExtension2, kTestPolicy2));

// Installing a new extension doesn't trigger another policy fetch because