DevTools: Decouple shortcuts from actions, introduce shortcut contexts

Source/devtools/front_end/Main.js

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2007 Matt Lilek (pewtermoose@gmail.com).
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 316 matching lines @@
 
         new WebInspector.DebuggerScriptMapping(WebInspector.debuggerModel, WebInspector.workspace, WebInspector.networkWorkspaceProvider);
         WebInspector.liveEditSupport = new WebInspector.LiveEditSupport(WebInspector.workspace);
         new WebInspector.CSSStyleSheetMapping(WebInspector.cssModel, WebInspector.workspace, WebInspector.networkWorkspaceProvider);
         new WebInspector.PresentationConsoleMessageHelper(WebInspector.workspace);
 
         // Create settings before loading modules.
         WebInspector.settings.initializeBackendSettings();
 
         this._registerModules();
-        WebInspector.KeyboardShortcut.registerActions();
+        WebInspector.moduleManager.instance(WebInspector.ActionRegistryAPI).registerActions();

[pfeldman, 2014/04/14 13:10:44]

You should depend on the action system directly - it can be a part of UI
component

[apavlov, 2014/04/15 13:33:14]

Done.

+        WebInspector.KeyboardShortcut.registerBindings();
 
         WebInspector.panels = {};
         WebInspector.inspectorView = new WebInspector.InspectorView();
         // Screencast controller creates a root view itself.
         if (mainTarget.canScreencast)
             this._screencastController = new WebInspector.ScreencastController();
         else
             this._createRootView();
         this._createGlobalStatusBarItems();
 
@@ skipping 185 matching lines @@
         if (!WebInspector.Dialog.currentInstance() && WebInspector.inspectElementModeController && WebInspector.inspectElementModeController.handleShortcut(event))
             return;
 
         var isValidZoomShortcut = WebInspector.KeyboardShortcut.eventHasCtrlOrMeta(event) &&
             !event.altKey &&
             !InspectorFrontendHost.isStub;
         if (!WebInspector.Dialog.currentInstance() && isValidZoomShortcut && this._handleZoomEvent(event)) {
             event.consume(true);
             return;
         }
-        WebInspector.KeyboardShortcut.handleShortcut(event);
+        WebInspector.KeyboardShortcut.handleShortcut(event, WebInspector.inspectorView.currentPanelId() || "");
     },
 
     _documentCanCopy: function(event)
     {
         if (WebInspector.inspectorView.currentPanel() && WebInspector.inspectorView.currentPanel()["handleCopyEvent"])
             event.preventDefault();
     },
 
     _documentCopy: function(event)
     {
@@ skipping 213 matching lines @@
 
 WebInspector.__defineGetter__("inspectedPageURL", function()
 {
     return WebInspector.resourceTreeModel.inspectedPageURL();
 });
 
 WebInspector.panel = function(name)
 {
     return WebInspector.inspectorView.panel(name);
 }