Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1810)

Unified Diff: Source/devtools/front_end/Main.js

Issue 218613013: DevTools: Decouple shortcuts from actions, introduce shortcut contexts (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix context-related sort order Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/Main.js
diff --git a/Source/devtools/front_end/Main.js b/Source/devtools/front_end/Main.js
index e82b996c20ca3afbbc468f8f0b6b93d244db3e77..1b33e72ad8c226df8a147a6ad2c4d3aa1883aced 100644
--- a/Source/devtools/front_end/Main.js
+++ b/Source/devtools/front_end/Main.js
@@ -334,7 +334,8 @@ WebInspector.Main.prototype = {
WebInspector.settings.initializeBackendSettings();
this._registerModules();
- WebInspector.KeyboardShortcut.registerActions();
+ WebInspector.moduleManager.instance(WebInspector.ActionRegistryAPI).registerActions();
pfeldman 2014/04/14 13:10:44 You should depend on the action system directly -
apavlov 2014/04/15 13:33:14 Done.
+ WebInspector.KeyboardShortcut.registerBindings();
WebInspector.panels = {};
WebInspector.inspectorView = new WebInspector.InspectorView();
@@ -540,7 +541,7 @@ WebInspector.Main.prototype = {
event.consume(true);
return;
}
- WebInspector.KeyboardShortcut.handleShortcut(event);
+ WebInspector.KeyboardShortcut.handleShortcut(event, WebInspector.inspectorView.currentPanelId() || "");
},
_documentCanCopy: function(event)

Powered by Google App Engine
This is Rietveld 408576698