Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 218613005: Remove unused GG_(U)INTn_C macros from base/port.h. (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Remove unused GG_(U)INTn_C macros from base/port.h. Also mark the remaining ones as deprecated. In Chromium, we force-define __STDC_CONSTANT_MACROS, so you can just use the regular (U)INTn_C macros from <stdint.h>. R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M base/port.h View 1 chunk +3 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 8 months ago (2014-03-31 15:03:00 UTC) #1
brettw
lgtm
6 years, 8 months ago (2014-03-31 16:23:27 UTC) #2
viettrungluu
6 years, 8 months ago (2014-03-31 16:56:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r260571 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698