Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: base/port.h

Issue 218613005: Remove unused GG_(U)INTn_C macros from base/port.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_PORT_H_ 5 #ifndef BASE_PORT_H_
6 #define BASE_PORT_H_ 6 #define BASE_PORT_H_
7 7
8 #include <stdarg.h> 8 #include <stdarg.h>
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 10
11 #ifdef COMPILER_MSVC 11 #ifdef COMPILER_MSVC
12 #define GG_LONGLONG(x) x##I64 12 #define GG_LONGLONG(x) x##I64
13 #define GG_ULONGLONG(x) x##UI64 13 #define GG_ULONGLONG(x) x##UI64
14 #else 14 #else
15 #define GG_LONGLONG(x) x##LL 15 #define GG_LONGLONG(x) x##LL
16 #define GG_ULONGLONG(x) x##ULL 16 #define GG_ULONGLONG(x) x##ULL
17 #endif 17 #endif
18 18
19 // Per C99 7.8.14, define __STDC_CONSTANT_MACROS before including <stdint.h> 19 // DEPRECATED: In Chromium, we force-define __STDC_CONSTANT_MACROS, so you can
20 // to get the INTn_C and UINTn_C macros for integer constants. It's difficult 20 // just use the regular (U)INTn_C macros from <stdint.h>.
21 // to guarantee any specific ordering of header includes, so it's difficult to 21 // TODO(viettrungluu): Remove the remaining GG_(U)INTn_C macros.
22 // guarantee that the INTn_C macros can be defined by including <stdint.h> at
23 // any specific point. Provide GG_INTn_C macros instead.
24
25 #define GG_INT8_C(x) (x)
26 #define GG_INT16_C(x) (x)
27 #define GG_INT32_C(x) (x)
28 #define GG_INT64_C(x) GG_LONGLONG(x) 22 #define GG_INT64_C(x) GG_LONGLONG(x)
29
30 #define GG_UINT8_C(x) (x ## U)
31 #define GG_UINT16_C(x) (x ## U)
32 #define GG_UINT32_C(x) (x ## U) 23 #define GG_UINT32_C(x) (x ## U)
33 #define GG_UINT64_C(x) GG_ULONGLONG(x) 24 #define GG_UINT64_C(x) GG_ULONGLONG(x)
34 25
35 // It's possible for functions that use a va_list, such as StringPrintf, to 26 // It's possible for functions that use a va_list, such as StringPrintf, to
36 // invalidate the data in it upon use. The fix is to make a copy of the 27 // invalidate the data in it upon use. The fix is to make a copy of the
37 // structure before using it and use that copy instead. va_copy is provided 28 // structure before using it and use that copy instead. va_copy is provided
38 // for this purpose. MSVC does not provide va_copy, so define an 29 // for this purpose. MSVC does not provide va_copy, so define an
39 // implementation here. It is not guaranteed that assignment is a copy, so the 30 // implementation here. It is not guaranteed that assignment is a copy, so the
40 // StringUtil.VariableArgsFunc unit test tests this capability. 31 // StringUtil.VariableArgsFunc unit test tests this capability.
41 #if defined(COMPILER_GCC) 32 #if defined(COMPILER_GCC)
42 #define GG_VA_COPY(a, b) (va_copy(a, b)) 33 #define GG_VA_COPY(a, b) (va_copy(a, b))
43 #elif defined(COMPILER_MSVC) 34 #elif defined(COMPILER_MSVC)
44 #define GG_VA_COPY(a, b) (a = b) 35 #define GG_VA_COPY(a, b) (a = b)
45 #endif 36 #endif
46 37
47 // Define an OS-neutral wrapper for shared library entry points 38 // Define an OS-neutral wrapper for shared library entry points
48 #if defined(OS_WIN) 39 #if defined(OS_WIN)
49 #define API_CALL __stdcall 40 #define API_CALL __stdcall
50 #else 41 #else
51 #define API_CALL 42 #define API_CALL
52 #endif 43 #endif
53 44
54 #endif // BASE_PORT_H_ 45 #endif // BASE_PORT_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698