Add gyp define to enable vulkan debug layers

Add gyp define to enable vulkan debug layers

On Debug vulkan bots, running with the debug layers on seems to be adding
more than an hour to the total running time. Since we suppress any output
on the bots anyways the debug layers are serving no purpose. Thus I am
adding a gyp define to disable the layers on the bot.

With this change, by default when running vulkan in Debug, the debug_layers
will be enabled. The bots should disable the layers. Android framework
should also have them disabled by default.

TBR=djsollen@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185953003

Committed: https://skia.googlesource.com/skia/+/735109c24892a95290974c9665527b57b01e5440

[egdaniel, 2016-07-27 14:07:10]

Description was changed from

==========
Add gyp define to enable vulkan debug layers

BUG=skia:
==========

to

==========
Add gyp define to enable vulkan debug layers

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185953003
==========

[egdaniel, 2016-07-27 14:13:38]

Description was changed from

==========
Add gyp define to enable vulkan debug layers

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185953003
==========

to

==========
Add gyp define to enable vulkan debug layers

On Debug vulkan bots, running with the debug layers on seems to be adding more
than an hour to the total running time. Since we suppress any output on the bots
anyways the debug layers are serving no purpose. Thus I am adding a gyp define
to disable the layers on the bot.

With this change, by default when running vulkan in Debug, the debug_layers will
be enabled. The bots should disable the layers. Android framework should also
have them disabled by default.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185953003
==========

[egdaniel, 2016-07-27 14:14:23]

Description was changed from

==========
Add gyp define to enable vulkan debug layers

On Debug vulkan bots, running with the debug layers on seems to be adding more
than an hour to the total running time. Since we suppress any output on the bots
anyways the debug layers are serving no purpose. Thus I am adding a gyp define
to disable the layers on the bot.

With this change, by default when running vulkan in Debug, the debug_layers will
be enabled. The bots should disable the layers. Android framework should also
have them disabled by default.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185953003
==========

to

==========
Add gyp define to enable vulkan debug layers

On Debug vulkan bots, running with the debug layers on seems to be adding
more than an hour to the total running time. Since we suppress any output
on the bots anyways the debug layers are serving no purpose. Thus I am
adding a gyp define to disable the layers on the bot.

With this change, by default when running vulkan in Debug, the debug_layers
will be enabled. The bots should disable the layers. Android framework
should also have them disabled by default.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185953003
==========

[egdaniel, 2016-07-27 14:15:25]

egdaniel@google.com changed reviewers:
+ borenet@google.com, djsollen@google.com, jvanverth@google.com

[egdaniel, 2016-07-27 14:15:25]

egdaniel@google.com changed reviewers:
+ borenet@google.com, djsollen@google.com, jvanverth@google.com

[egdaniel, 2016-07-27 14:15:26]

Adding Jim for general change, Eric for bots, and Derek for android.

[egdaniel, 2016-07-27 14:15:26]

Adding Jim for general change, Eric for bots, and Derek for android.

[egdaniel, 2016-07-27 14:16:39]

The CQ bit was checked by egdaniel@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 14:16:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[djsollen, 2016-07-27 14:24:25]

android looks good

[borenet, 2016-07-27 14:36:36]

Bots stuff lgtm

[jvanverth1, 2016-07-27 14:44:41]

lgtm

[egdaniel, 2016-07-27 14:56:29]

The CQ bit was unchecked by egdaniel@google.com

[egdaniel, 2016-07-27 14:56:33]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2016-07-27 14:56:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 14:58:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 14:58:15]

Try jobs failed on following builders:
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[egdaniel, 2016-07-27 14:59:45]

Description was changed from

==========
Add gyp define to enable vulkan debug layers

On Debug vulkan bots, running with the debug layers on seems to be adding
more than an hour to the total running time. Since we suppress any output
on the bots anyways the debug layers are serving no purpose. Thus I am
adding a gyp define to disable the layers on the bot.

With this change, by default when running vulkan in Debug, the debug_layers
will be enabled. The bots should disable the layers. Android framework
should also have them disabled by default.


BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185953003
==========

to

==========
Add gyp define to enable vulkan debug layers

On Debug vulkan bots, running with the debug layers on seems to be adding
more than an hour to the total running time. Since we suppress any output
on the bots anyways the debug layers are serving no purpose. Thus I am
adding a gyp define to disable the layers on the bot.

With this change, by default when running vulkan in Debug, the debug_layers
will be enabled. The bots should disable the layers. Android framework
should also have them disabled by default.

TBR=djsollen@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185953003
==========

[egdaniel, 2016-07-27 14:59:51]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2016-07-27 14:59:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 15:04:00]

Description was changed from

==========
Add gyp define to enable vulkan debug layers

On Debug vulkan bots, running with the debug layers on seems to be adding
more than an hour to the total running time. Since we suppress any output
on the bots anyways the debug layers are serving no purpose. Thus I am
adding a gyp define to disable the layers on the bot.

With this change, by default when running vulkan in Debug, the debug_layers
will be enabled. The bots should disable the layers. Android framework
should also have them disabled by default.

TBR=djsollen@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185953003
==========

to

==========
Add gyp define to enable vulkan debug layers

On Debug vulkan bots, running with the debug layers on seems to be adding
more than an hour to the total running time. Since we suppress any output
on the bots anyways the debug layers are serving no purpose. Thus I am
adding a gyp define to disable the layers on the bot.

With this change, by default when running vulkan in Debug, the debug_layers
will be enabled. The bots should disable the layers. Android framework
should also have them disabled by default.

TBR=djsollen@google.com

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2185953003

Committed:
https://skia.googlesource.com/skia/+/735109c24892a95290974c9665527b57b01e5440
==========

[commit-bot: I haz the power, 2016-07-27 15:04:01]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/735109c24892a95290974c9665527b57b01e5440