Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2185913003: [debugger] Scope iterator should not visit inner function literals. (Closed)

Created:
4 years, 4 months ago by Yang
Modified:
4 years, 4 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] Scope iterator should not visit inner function literals. R=marja@chromium.org BUG=chromium:621361 Committed: https://crrev.com/071b655fa90a3db1f41717f28cb50fe9f2c6db2c Cr-Commit-Position: refs/heads/master@{#38087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M src/debug/debug-scopes.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-621361.js View 1 chunk +40 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Yang
4 years, 4 months ago (2016-07-27 08:24:15 UTC) #1
marja
lgtm
4 years, 4 months ago (2016-07-27 08:29:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185913003/1
4 years, 4 months ago (2016-07-27 08:31:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 09:01:07 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 09:04:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/071b655fa90a3db1f41717f28cb50fe9f2c6db2c
Cr-Commit-Position: refs/heads/master@{#38087}

Powered by Google App Engine
This is Rietveld 408576698