[inspector] add inspector protocol parser test build target.

[inspector] add inspector protocol parser test build target for GYP.

This adds the build target inspector_protocol_parser_test, which depends
on several more inspector protocol related targets. The resulting
gtest executable runs, but has failures that have to be fixed.

GN build configuration will follow.

A copy of v8-inspector/js_protocol.json has been included to be able to
use it before the actual migration.

BUG=chromium:580337
Committed: https://crrev.com/f7fa02f8b288c8b003a556184d4c5ed2d9f53116
Cr-Commit-Position: refs/heads/master@{#38111}

[Yang, 2016-07-26 13:25:00]

Description was changed from

==========
[inspector] add inspector parser test build target.


BUG=chromium:580337
==========

to

==========
[inspector] add inspector parser test build target for GYP.

This adds the build target inspector_protocol_parser_test, which depends
on several more inspector protocol related targets. The resulting
gtest executable runs, but has failures that have to be fixed.

GN build configuration will follow.

BUG=chromium:580337
==========

[Yang, 2016-07-26 13:26:53]

Description was changed from

==========
[inspector] add inspector parser test build target for GYP.

This adds the build target inspector_protocol_parser_test, which depends
on several more inspector protocol related targets. The resulting
gtest executable runs, but has failures that have to be fixed.

GN build configuration will follow.

BUG=chromium:580337
==========

to

==========
[inspector] add inspector parser test build target for GYP.

This adds the build target inspector_protocol_parser_test, which depends
on several more inspector protocol related targets. The resulting
gtest executable runs, but has failures that have to be fixed.

GN build configuration will follow.

markupsafe has been included because a git mirror does not exist yet.
(see issue chromium:630576)

A copy of v8-inspector/js_protocol.json has been included to be able to
use it before the actual migration.

BUG=chromium:580337
==========

[Yang, 2016-07-26 13:27:04]

Description was changed from

==========
[inspector] add inspector parser test build target for GYP.

This adds the build target inspector_protocol_parser_test, which depends
on several more inspector protocol related targets. The resulting
gtest executable runs, but has failures that have to be fixed.

GN build configuration will follow.

markupsafe has been included because a git mirror does not exist yet.
(see issue chromium:630576)

A copy of v8-inspector/js_protocol.json has been included to be able to
use it before the actual migration.

BUG=chromium:580337
==========

to

==========
[inspector] add inspector parser test build target for GYP.

This adds the build target inspector_protocol_parser_test, which depends
on several more inspector protocol related targets. The resulting
gtest executable runs, but has failures that have to be fixed.

GN build configuration will follow.

Markupsafe has been included because a git mirror does not exist yet.
(see issue chromium:630576)

A copy of v8-inspector/js_protocol.json has been included to be able to
use it before the actual migration.

BUG=chromium:580337
==========

[Yang, 2016-07-26 13:27:47]

Description was changed from

==========
[inspector] add inspector parser test build target for GYP.

This adds the build target inspector_protocol_parser_test, which depends
on several more inspector protocol related targets. The resulting
gtest executable runs, but has failures that have to be fixed.

GN build configuration will follow.

Markupsafe has been included because a git mirror does not exist yet.
(see issue chromium:630576)

A copy of v8-inspector/js_protocol.json has been included to be able to
use it before the actual migration.

BUG=chromium:580337
==========

to

==========
[inspector] add inspector protocol parser test build target for GYP.

This adds the build target inspector_protocol_parser_test, which depends
on several more inspector protocol related targets. The resulting
gtest executable runs, but has failures that have to be fixed.

GN build configuration will follow.

Markupsafe has been included because a git mirror does not exist yet.
(see issue chromium:630576)

A copy of v8-inspector/js_protocol.json has been included to be able to
use it before the actual migration.

BUG=chromium:580337
==========

[Yang, 2016-07-26 13:28:16]

yangguo@chromium.org changed reviewers:
+ jochen@chromium.org, machenbach@chromium.org, pfeldman@chromium.org

[Yang, 2016-07-26 13:28:17]

Please take a look. I'm still unsure about where to place the new files, so
suggestions are welcome!

[Michael Achenbach, 2016-07-26 14:27:45]

copying markupsafe for now lg

https://codereview.chromium.org/2184733002/diff/20001/src/v8-inspector/inspec...
File src/v8-inspector/inspector.gyp (right):

https://codereview.chromium.org/2184733002/diff/20001/src/v8-inspector/inspec...
src/v8-inspector/inspector.gyp:4: 
Reviewed gyp consistency. Somebody with more knowledge of the used tools should
probably review this too.

https://codereview.chromium.org/2184733002/diff/20001/src/v8-inspector/inspec...
src/v8-inspector/inspector.gyp:89: '../../testing/gmock.gyp:gmock',
Why is this dependent on gmock and gtest and not the test executable below?

https://codereview.chromium.org/2184733002/diff/20001/src/v8-inspector/js_pro...
File src/v8-inspector/js_protocol.json (right):

https://codereview.chromium.org/2184733002/diff/20001/src/v8-inspector/js_pro...
src/v8-inspector/js_protocol.json:1: {
No idea about this.

https://codereview.chromium.org/2184733002/diff/20001/src/v8.gyp
File src/v8.gyp (right):

https://codereview.chromium.org/2184733002/diff/20001/src/v8.gyp#newcode2316
src/v8.gyp:2316: { 'target_name': 'inspector_protocol',
Don't think we need this here, maybe rather add this to all.gypi.

Also, inspector_protocol is a static library. Why have this as a standalone
target?

[Yang, 2016-07-27 06:42:25]

Removed markupsafe check in since we now have a git mirror to DEPS from.

https://codereview.chromium.org/2184733002/diff/20001/src/v8-inspector/inspec...
File src/v8-inspector/inspector.gyp (right):

https://codereview.chromium.org/2184733002/diff/20001/src/v8-inspector/inspec...
src/v8-inspector/inspector.gyp:89: '../../testing/gmock.gyp:gmock',
On 2016/07/26 14:27:45, Michael Achenbach (slow) wrote:
> Why is this dependent on gmock and gtest and not the test executable below?

You are right. Fixed.

https://codereview.chromium.org/2184733002/diff/20001/src/v8-inspector/js_pro...
File src/v8-inspector/js_protocol.json (right):

https://codereview.chromium.org/2184733002/diff/20001/src/v8-inspector/js_pro...
src/v8-inspector/js_protocol.json:1: {
On 2016/07/26 14:27:45, Michael Achenbach (slow) wrote:
> No idea about this.

This is just checked in temporarily for the sake of using it for the build.
Eventually, we will replace it with the updated version once v8-inspector
migrates completely to src/inspector.

https://codereview.chromium.org/2184733002/diff/20001/src/v8.gyp
File src/v8.gyp (right):

https://codereview.chromium.org/2184733002/diff/20001/src/v8.gyp#newcode2316
src/v8.gyp:2316: { 'target_name': 'inspector_protocol',
On 2016/07/26 14:27:45, Michael Achenbach (slow) wrote:
> Don't think we need this here, maybe rather add this to all.gypi.
> 
> Also, inspector_protocol is a static library. Why have this as a standalone
> target?

Done.

[Yang, 2016-07-27 06:42:51]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 06:43:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Achenbach, 2016-07-27 06:49:04]

lgtm ~ comments

https://codereview.chromium.org/2184733002/diff/40001/DEPS
File DEPS (right):

https://codereview.chromium.org/2184733002/diff/40001/DEPS#newcode21
DEPS:21: Var("git_url") +
"/chromium/src/third_party/WebKit/Source/platform/inspector_protocol.git" + "@"
+ "35e3f59ad05d994f163e82f9e644f18f9e708fec",
Please add to .gitignore. Other thirdparty cases are listed there explicitly.

https://codereview.chromium.org/2184733002/diff/40001/gypfiles/all.gyp
File gypfiles/all.gyp (right):

https://codereview.chromium.org/2184733002/diff/40001/gypfiles/all.gyp#newcode12
gypfiles/all.gyp:12:
'../src/inspector/inspector.gyp:inspector_protocol_parser_test',
I wonder what is the reason for cctest and unittests being in the block below.
Maybe it's due to gmock and gtest? Then this new test would have the same
problem. Maybe move it there too?

[Yang, 2016-07-27 07:14:39]

https://codereview.chromium.org/2184733002/diff/40001/DEPS
File DEPS (right):

https://codereview.chromium.org/2184733002/diff/40001/DEPS#newcode21
DEPS:21: Var("git_url") +
"/chromium/src/third_party/WebKit/Source/platform/inspector_protocol.git" + "@"
+ "35e3f59ad05d994f163e82f9e644f18f9e708fec",
On 2016/07/27 06:49:04, Michael Achenbach (slow) wrote:
> Please add to .gitignore. Other thirdparty cases are listed there explicitly.

Done.

https://codereview.chromium.org/2184733002/diff/40001/gypfiles/all.gyp
File gypfiles/all.gyp (right):

https://codereview.chromium.org/2184733002/diff/40001/gypfiles/all.gyp#newcode12
gypfiles/all.gyp:12:
'../src/inspector/inspector.gyp:inspector_protocol_parser_test',
On 2016/07/27 06:49:04, Michael Achenbach (slow) wrote:
> I wonder what is the reason for cctest and unittests being in the block below.
> Maybe it's due to gmock and gtest? Then this new test would have the same
> problem. Maybe move it there too?

Done.

[Yang, 2016-07-27 07:14:44]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 07:14:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-07-27 07:18:24]

won't you have to teach run-tests.py about how to run the tests?

why no isolate file?

why not include the gn configuration in this CL?

[Michael Achenbach, 2016-07-27 07:31:52]

On 2016/07/27 07:18:24, jochen wrote:
> won't you have to teach run-tests.py about how to run the tests?
> 
> why no isolate file?
> 
> why not include the gn configuration in this CL?

I understood that the plan was to do these changes incrementally later. This
should be enough to enable local testing with gyp.

[Michael Achenbach, 2016-07-27 07:32:42]

Btw: Please update the CL desc regarding markupsafe

[commit-bot: I haz the power, 2016-07-27 07:36:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 07:36:34]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-07-27 07:39:43]

Description was changed from

==========
[inspector] add inspector protocol parser test build target for GYP.

This adds the build target inspector_protocol_parser_test, which depends
on several more inspector protocol related targets. The resulting
gtest executable runs, but has failures that have to be fixed.

GN build configuration will follow.

Markupsafe has been included because a git mirror does not exist yet.
(see issue chromium:630576)

A copy of v8-inspector/js_protocol.json has been included to be able to
use it before the actual migration.

BUG=chromium:580337
==========

to

==========
[inspector] add inspector protocol parser test build target for GYP.

This adds the build target inspector_protocol_parser_test, which depends
on several more inspector protocol related targets. The resulting
gtest executable runs, but has failures that have to be fixed.

GN build configuration will follow.

A copy of v8-inspector/js_protocol.json has been included to be able to
use it before the actual migration.

BUG=chromium:580337
==========

[Yang, 2016-07-27 07:40:20]

On 2016/07/27 07:32:42, Michael Achenbach (slow) wrote:
> Btw: Please update the CL desc regarding markupsafe

Updated description.

And yes, I want to do things step by step. GN build and test configuration will
follow.

[jochen (gone - plz use gerrit), 2016-07-27 07:58:07]

can we please at least include gn rules?

I'd rather not have gn and gyp divert

[Yang, 2016-07-27 08:00:25]

On 2016/07/27 07:58:07, jochen wrote:
> can we please at least include gn rules?
> 
> I'd rather not have gn and gyp divert

okay. will work on this :)

[Yang, 2016-07-27 10:41:42]

On 2016/07/27 08:00:25, Yang wrote:
> On 2016/07/27 07:58:07, jochen wrote:
> > can we please at least include gn rules?
> > 
> > I'd rather not have gn and gyp divert
> 
> okay. will work on this :)

Added build file for GN.

[Yang, 2016-07-27 10:41:47]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 10:41:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-07-27 10:44:28]

lgtm

[commit-bot: I haz the power, 2016-07-27 10:47:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 10:47:26]

Dry run: Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[Michael Achenbach, 2016-07-27 11:38:31]

Please add the target also to gn_all in the toplevel BUILD.gn so that it is
build on chromium trybots. I have a selection of bots that give good coverage...
will trigger them here

[Yang, 2016-07-27 12:06:59]

On 2016/07/27 11:38:31, Michael Achenbach (slow) wrote:
> Please add the target also to gn_all in the toplevel BUILD.gn so that it is
> build on chromium trybots. I have a selection of bots that give good
coverage...
> will trigger them here

I have created separate build files for the test target, which now looks similar
to cctest or unittests. So I added that target to test:gn_all.

[Yang, 2016-07-27 12:11:36]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 12:11:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 12:32:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 12:32:17]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-07-27 13:09:40]

https://codereview.chromium.org/2184733002/diff/140001/src/inspector/BUILD.gn
File src/inspector/BUILD.gn (right):

https://codereview.chromium.org/2184733002/diff/140001/src/inspector/BUILD.gn...
src/inspector/BUILD.gn:25: output_file = "$target_gen_dir/protocol.json"
Who reads the output_file? The action below depends on this but it is not
obvious to me if it actually needs this output_file. It gets target_gen_dir as
--output_dir which doesn't sound like script input.

https://codereview.chromium.org/2184733002/diff/140001/test/inspector_protoco...
File test/inspector_protocol_parser_test/BUILD.gn (right):

https://codereview.chromium.org/2184733002/diff/140001/test/inspector_protoco...
test/inspector_protocol_parser_test/BUILD.gn:18: "//",
Is this needed? Might be default in gn, not sure.

[Yang, 2016-07-27 13:15:14]

https://codereview.chromium.org/2184733002/diff/140001/src/inspector/BUILD.gn
File src/inspector/BUILD.gn (right):

https://codereview.chromium.org/2184733002/diff/140001/src/inspector/BUILD.gn...
src/inspector/BUILD.gn:25: output_file = "$target_gen_dir/protocol.json"
On 2016/07/27 13:09:40, Michael Achenbach (slow) wrote:
> Who reads the output_file? The action below depends on this but it is not
> obvious to me if it actually needs this output_file. It gets target_gen_dir as
> --output_dir which doesn't sound like script input.

I blindly took that over from blink. I dug a bit deeper, and, you are right, we
don't need this.

https://codereview.chromium.org/2184733002/diff/140001/test/inspector_protoco...
File test/inspector_protocol_parser_test/BUILD.gn (right):

https://codereview.chromium.org/2184733002/diff/140001/test/inspector_protoco...
test/inspector_protocol_parser_test/BUILD.gn:18: "//",
On 2016/07/27 13:09:40, Michael Achenbach (slow) wrote:
> Is this needed? Might be default in gn, not sure.

Removed.

[Michael Achenbach, 2016-07-27 14:16:25]

lgtm

https://codereview.chromium.org/2184733002/diff/140001/src/inspector/BUILD.gn
File src/inspector/BUILD.gn (right):

https://codereview.chromium.org/2184733002/diff/140001/src/inspector/BUILD.gn...
src/inspector/BUILD.gn:25: output_file = "$target_gen_dir/protocol.json"
On 2016/07/27 13:15:14, Yang wrote:
> On 2016/07/27 13:09:40, Michael Achenbach (slow) wrote:
> > Who reads the output_file? The action below depends on this but it is not
> > obvious to me if it actually needs this output_file. It gets target_gen_dir
as
> > --output_dir which doesn't sound like script input.
> 
> I blindly took that over from blink. I dug a bit deeper, and, you are right,
we
> don't need this.

Awesome if it works like this. Hope there is no hidden catch.

[Yang, 2016-07-28 06:30:37]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-07-28 06:30:37]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2184733002/#ps30023
(title: "address comments")

[commit-bot: I haz the power, 2016-07-28 06:30:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 06:53:53]

Description was changed from

==========
[inspector] add inspector protocol parser test build target for GYP.

This adds the build target inspector_protocol_parser_test, which depends
on several more inspector protocol related targets. The resulting
gtest executable runs, but has failures that have to be fixed.

GN build configuration will follow.

A copy of v8-inspector/js_protocol.json has been included to be able to
use it before the actual migration.

BUG=chromium:580337
==========

to

==========
[inspector] add inspector protocol parser test build target for GYP.

This adds the build target inspector_protocol_parser_test, which depends
on several more inspector protocol related targets. The resulting
gtest executable runs, but has failures that have to be fixed.

GN build configuration will follow.

A copy of v8-inspector/js_protocol.json has been included to be able to
use it before the actual migration.

BUG=chromium:580337
==========

[commit-bot: I haz the power, 2016-07-28 06:53:54]

Committed patchset #9 (id:30023)

[commit-bot: I haz the power, 2016-07-28 06:57:15]

Description was changed from

==========
[inspector] add inspector protocol parser test build target for GYP.

This adds the build target inspector_protocol_parser_test, which depends
on several more inspector protocol related targets. The resulting
gtest executable runs, but has failures that have to be fixed.

GN build configuration will follow.

A copy of v8-inspector/js_protocol.json has been included to be able to
use it before the actual migration.

BUG=chromium:580337
==========

to

==========
[inspector] add inspector protocol parser test build target for GYP.

This adds the build target inspector_protocol_parser_test, which depends
on several more inspector protocol related targets. The resulting
gtest executable runs, but has failures that have to be fixed.

GN build configuration will follow.

A copy of v8-inspector/js_protocol.json has been included to be able to
use it before the actual migration.

BUG=chromium:580337

Committed: https://crrev.com/f7fa02f8b288c8b003a556184d4c5ed2d9f53116
Cr-Commit-Position: refs/heads/master@{#38111}
==========

[commit-bot: I haz the power, 2016-07-28 06:57:16]

Patchset 9 (id:??) landed as
https://crrev.com/f7fa02f8b288c8b003a556184d4c5ed2d9f53116
Cr-Commit-Position: refs/heads/master@{#38111}

[Yang, 2016-07-28 10:27:08]

Description was changed from

==========
[inspector] add inspector protocol parser test build target for GYP.

This adds the build target inspector_protocol_parser_test, which depends
on several more inspector protocol related targets. The resulting
gtest executable runs, but has failures that have to be fixed.

GN build configuration will follow.

A copy of v8-inspector/js_protocol.json has been included to be able to
use it before the actual migration.

BUG=chromium:580337

Committed: https://crrev.com/f7fa02f8b288c8b003a556184d4c5ed2d9f53116
Cr-Commit-Position: refs/heads/master@{#38111}
==========

to

==========
[inspector] add inspector protocol parser test build target for GYP.

This adds the build target inspector_protocol_parser_test, which depends
on several more inspector protocol related targets. The resulting
gtest executable runs, but has failures that have to be fixed.

GN build configuration will follow.

A copy of v8-inspector/js_protocol.json has been included to be able to
use it before the actual migration.

BUG=chromium:580337

Committed: https://crrev.com/f7fa02f8b288c8b003a556184d4c5ed2d9f53116
Cr-Commit-Position: refs/heads/master@{#38111}
==========