Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2185873002: Default trailing comma support to `true` (#26647). (Closed)

Created:
4 years, 4 months ago by pquitslund
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -74 lines) Patch
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/completion_target_test.dart View 2 chunks +2 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +0 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 3 chunks +2 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 3 chunks +1 line, -11 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 11 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
pquitslund
4 years, 4 months ago (2016-07-26 22:28:31 UTC) #2
pquitslund
On 2016/07/26 22:28:31, pquitslund wrote: Incidentally, you may wonder why this is completely removing the ...
4 years, 4 months ago (2016-07-26 22:30:34 UTC) #3
scheglov
lgtm
4 years, 4 months ago (2016-07-27 00:46:04 UTC) #4
Brian Wilkerson
Are trailing commas supported everywhere? If not, it seems like we ought to wait, otherwise ...
4 years, 4 months ago (2016-07-27 15:07:47 UTC) #5
pquitslund
On 2016/07/27 15:07:47, Brian Wilkerson wrote: > Are trailing commas supported everywhere? If not, it ...
4 years, 4 months ago (2016-07-27 16:16:46 UTC) #6
Brian Wilkerson
In that case, lgtm.
4 years, 4 months ago (2016-07-27 16:19:02 UTC) #7
pquitslund
4 years, 4 months ago (2016-07-27 16:42:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
722d4a13b04c7b4f1d021c7157380d758c9f9a43 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698