Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1751)

Unified Diff: pkg/analysis_server/test/services/completion/completion_target_test.dart

Issue 2185873002: Default trailing comma support to `true` (#26647). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/context_manager_test.dart ('k') | pkg/analyzer/lib/src/context/context.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/completion_target_test.dart
diff --git a/pkg/analysis_server/test/services/completion/completion_target_test.dart b/pkg/analysis_server/test/services/completion/completion_target_test.dart
index f7cca21b8d96b746e60d1a52e2c137b1636da2d7..ce023433eeeb77d456ecfc14d8942908e9f93569 100644
--- a/pkg/analysis_server/test/services/completion/completion_target_test.dart
+++ b/pkg/analysis_server/test/services/completion/completion_target_test.dart
@@ -64,11 +64,7 @@ class CompletionTargetTest extends AbstractContextTest {
test_ArgumentList_InstanceCreationExpression2() {
// ArgumentList InstanceCreationExpression Block
addTestSource('main() {new Foo(a,^)}');
- if (context.analysisOptions.enableTrailingCommas) {
- assertTarget(')', '(a)', argIndex: 1);
- } else {
- assertTarget('', '(a, )', argIndex: 1);
- }
+ assertTarget(')', '(a)', argIndex: 1);
}
test_ArgumentList_InstanceCreationExpression_functionArg2() {
@@ -104,11 +100,7 @@ class CompletionTargetTest extends AbstractContextTest {
test_ArgumentList_MethodInvocation4() {
// ArgumentList MethodInvocation Block
addTestSource('main() {foo(n,^)}');
- if (context.analysisOptions.enableTrailingCommas) {
- assertTarget(')', '(n)', argIndex: 1);
- } else {
- assertTarget('', '(n, )', argIndex: 1);
- }
+ assertTarget(')', '(n)', argIndex: 1);
}
test_ArgumentList_MethodInvocation_functionArg() {
« no previous file with comments | « pkg/analysis_server/test/context_manager_test.dart ('k') | pkg/analyzer/lib/src/context/context.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698