Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2185833002: [Mac/GN] Specify the ASan dynamic runtime as a bundle_data deps. (Closed)

Created:
4 years, 4 months ago by Robert Sesek
Modified:
4 years, 4 months ago
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-content_chromium.org, jam, jochen+watch_chromium.org, darin-cc_chromium.org, Alexander Potapenko
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Specify the ASan dynamic runtime as a bundle_data deps. This causes the ASan library to be copied into a bundle's Contents/MacOS/ directory, so it can be loaded via its @executable_path install name. BUG=630322 Committed: https://crrev.com/1cfe20c37872faa5e4d94b9a3b35959294de9462 Cr-Commit-Position: refs/heads/master@{#408174}

Patch Set 1 #

Patch Set 2 : Revert mb change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M build/config/sanitizers/BUILD.gn View 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/BUILD.gn View 1 3 chunks +8 lines, -0 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Robert Sesek
4 years, 4 months ago (2016-07-27 15:47:29 UTC) #4
Dirk Pranke
lgtm, seems straightforward enough.
4 years, 4 months ago (2016-07-27 16:48:22 UTC) #7
Robert Sesek
+avi for //content OWNERS
4 years, 4 months ago (2016-07-27 17:20:39 UTC) #9
Avi (use Gerrit)
lgtm stampity stamp
4 years, 4 months ago (2016-07-27 17:25:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185833002/20001
4 years, 4 months ago (2016-07-27 17:40:28 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-27 17:45:05 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 17:47:46 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1cfe20c37872faa5e4d94b9a3b35959294de9462
Cr-Commit-Position: refs/heads/master@{#408174}

Powered by Google App Engine
This is Rietveld 408576698