Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4192)

Unified Diff: chrome/BUILD.gn

Issue 2185833002: [Mac/GN] Specify the ASan dynamic runtime as a bundle_data deps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert mb change Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/sanitizers/BUILD.gn ('k') | content/shell/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index b4f53aeac8ea3b73665c19d59425a3c3f7eb2299..f27421aa9b39cb1be934c99e14fa036b0e657f65 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -514,6 +514,7 @@ if (is_win) {
":chrome_app_strings_bundle_data",
":chrome_resources",
":chrome_versioned_bundle_data",
+ "//build/config/sanitizers:deps",
"//chrome/common:version_header",
]
@@ -676,6 +677,7 @@ if (is_win) {
defines = [ "HELPER_EXECUTABLE" ]
deps = [
+ "//build/config/sanitizers:deps",
"//chrome/common:version_header",
]
@@ -727,6 +729,12 @@ if (is_win) {
public_deps = [
"//third_party/crashpad/crashpad/handler:crashpad_handler",
]
+
+ if (using_sanitizer) {
+ # crashpad_handler requires the ASan runtime at its @executable_path.
+ sources += [ "$root_out_dir/libclang_rt.asan_osx_dynamic.dylib" ]
+ public_deps += [ "//build/config/sanitizers:copy_asan_runtime" ]
+ }
}
bundle_data("chrome_framework_resources") {
« no previous file with comments | « build/config/sanitizers/BUILD.gn ('k') | content/shell/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698