Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: infra/libs/gerrit_api/test/gerrit_api_test.py

Issue 2185653002: gerrit_api: add on_behalf_of to set_review method. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@tag-631471
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « infra/libs/gerrit_api/gerrit_api.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/libs/gerrit_api/test/gerrit_api_test.py
diff --git a/infra/libs/gerrit_api/test/gerrit_api_test.py b/infra/libs/gerrit_api/test/gerrit_api_test.py
index 12fdd91024e2712a3ea2551385189fd4b9e36874..b7a476b1a594fdd1c1462e6d6530239b81dfa2fd 100644
--- a/infra/libs/gerrit_api/test/gerrit_api_test.py
+++ b/infra/libs/gerrit_api/test/gerrit_api_test.py
@@ -33,6 +33,7 @@ TEST_PAYLOAD = {
'message': 'Test message.',
'notify': 'NONE',
'tag': 'cq',
+ 'on_behalf_of': 'john@doe.net',
}
TEST_PAYLOAD_LABELS_ONLY = {
@@ -502,7 +503,8 @@ class GerritAgentTestCase(unittest.TestCase):
'%s%s' % (GERRIT_JSON_HEADER,
json.dumps({'labels':{'Code-Review':1}})), 200)
self.gerrit.set_review('change_id', 'revision_id', 'Test message.',
- { 'Code-Review': 1 }, tag='cq')
+ { 'Code-Review': 1 }, tag='cq',
+ on_behalf_of='john@doe.net')
mock_method.assert_called_once_with(
data=json.dumps(TEST_PAYLOAD),
method='POST',
« no previous file with comments | « infra/libs/gerrit_api/gerrit_api.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698