gerrit_api: add on_behalf_of to set_review method.

infra/libs/gerrit_api/test/gerrit_api_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Tests for gerrit_api.py"""
 
 import copy
 import json
 import mock
 import requests
@@ skipping 15 matching lines @@
 HEADERS_WITH_CONTENT_TYPE = HEADERS.copy()
 HEADERS_WITH_CONTENT_TYPE['Content-Type'] = 'application/json;charset=UTF-8'
 
 TEST_PAYLOAD = {
     'labels': {
         'Code-Review': 1,
     },
     'message': 'Test message.',
     'notify': 'NONE',
     'tag': 'cq',
+    'on_behalf_of': 'john@doe.net',
 }
 
 TEST_PAYLOAD_LABELS_ONLY = {
     'labels': {
         'Code-Review': 1,
     },
     'notify': 'OWNER',
 }
 
 TEST_CHANGE_INFO = {
@@ skipping 449 matching lines @@
     mock_method.return_value = _create_mock_return(None, 500)
     self.assertRaises(gerrit_api.UnexpectedResponseException,
                       self.gerrit.get_issue, 'issue')
 
   @mock.patch.object(requests.Session, 'request')
   def test_set_review(self, mock_method):
     mock_method.return_value = _create_mock_return(
         '%s%s' % (GERRIT_JSON_HEADER,
                   json.dumps({'labels':{'Code-Review':1}})), 200)
     self.gerrit.set_review('change_id', 'revision_id', 'Test message.',
-                           { 'Code-Review': 1 }, tag='cq')
+                           { 'Code-Review': 1 }, tag='cq',
+                           on_behalf_of='john@doe.net')
     mock_method.assert_called_once_with(
         data=json.dumps(TEST_PAYLOAD),
         method='POST',
         params=None,
         url=('https://chromium-review.googlesource.com/a/changes/'
              'change_id/revisions/revision_id/review'),
         headers=HEADERS_WITH_CONTENT_TYPE,
         hooks=self.gerrit._instrumentation_hooks)
 
   @mock.patch.object(requests.Session, 'request')
@@ skipping 38 matching lines @@
     mock_method.return_value = _create_mock_return(
         'revision revision_id is not current revision', 409)
     self.assertRaises(gerrit_api.RevisionConflictException,
                       self.gerrit.submit_revision, 'change_id', 'revision_id')
 
   @mock.patch.object(requests.Session, 'request')
   def test_submit_revision_unexpected_response(self, mock_method):
     mock_method.return_value = _create_mock_return(None, 500)
     self.assertRaises(gerrit_api.UnexpectedResponseException,
                       self.gerrit.submit_revision, 'change_id', 'revision_id')