Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Issue 2185623002: [Interpreter] Fix compiler.cc to consistently check for FLAG_ignition in ShouldUseIgnition. (Closed)

Created:
4 years, 4 months ago by rmcilroy
Modified:
4 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Fix compiler.cc to consistently check for FLAG_ignition in ShouldUseIgnition. BUG=chromium:631158 Committed: https://crrev.com/ae752848c8fd88a9b002fb1cc704413afa0bc897 Cr-Commit-Position: refs/heads/master@{#38058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/compiler.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
rmcilroy
PTAL thanks.
4 years, 4 months ago (2016-07-26 13:48:36 UTC) #4
Michael Starzinger
LGTM.
4 years, 4 months ago (2016-07-26 13:50:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185623002/1
4 years, 4 months ago (2016-07-26 14:45:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 14:46:26 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 14:49:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae752848c8fd88a9b002fb1cc704413afa0bc897
Cr-Commit-Position: refs/heads/master@{#38058}

Powered by Google App Engine
This is Rietveld 408576698